Merge remote-tracking branch 'origin/main' into sync-7-11-15-22

angular/src/directives/control-value-accessors/value-accessor.ts

@@ -96,14 +96,8 @@ export class ValueAccessor implements ControlValueAccessor, AfterViewInit, OnDes
     }
 
     /**
-     * TODO Remove this in favor of https://github.com/angular/angular/issues/10887
-     * whenever it is implemented. Currently, Ionic's form status classes
-     * do not react to changes when developers manually call
-     * Angular form control methods such as markAsTouched.
-     * This results in Ionic's form status classes being out
-     * of sync with the ng form status classes.
-     * This patches the methods to manually sync
-     * the classes until this feature is implemented in Angular.
+     * TODO FW-2787: Remove this in favor of https://github.com/angular/angular/issues/10887
+     * whenever it is implemented.
      */
     const formControl = ngControl.control as any;
     if (formControl) {

angular/src/directives/navigation/stack-utils.ts

@@ -74,7 +74,6 @@ export const toSegments = (path: string): string[] => {
 
 export const destroyView = (view: RouteView | undefined): void => {
   if (view) {
-    // TODO lifecycle event
     view.ref.destroy();
     view.unlistenEvents();
   }

angular/src/directives/overlays/popover.ts

@@ -108,7 +108,7 @@ export class IonPopover {
   constructor(c: ChangeDetectorRef, r: ElementRef, protected z: NgZone) {
     this.el = r.nativeElement;
 
-    this.el.addEventListener('willPresent', () => {
+    this.el.addEventListener('ionMount', () => {
       this.isCmpOpen = true;
       c.detectChanges();
     });

angular/src/util/overlay.ts

@@ -11,7 +11,6 @@ export class OverlayBaseController<Opts, Overlay> implements ControllerShape<Opt
    * Creates a new overlay
    */
   create(opts?: Opts): Promise<Overlay> {
-    // TODO: next major release opts is not optional
     return this.ctrl.create((opts || {}) as any);
   }