javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 16:16:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

test: migrate form control usages to modern syntax (#28897)

Browse Source 
Issue number: Internal

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Several tests were still using the legacy form syntax.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Migrated tests in `core`, `angular`, and `vue` to use the modern form
syntax (`react` did not have form controls).

I opted not to migrate `item/test/highlight` and `item/test/counter`
because those tests are going to be removed in the future once the
deprecate item APIs are removed.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

---------

Co-authored-by: ionitron <hi@ionicframework.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
This commit is contained in:
Liam DeBeasi
2024-01-30 11:14:02 -05:00
committed by GitHub
parent f6fc22bba6
commit bf34e0e247
123 changed files with 164 additions and 323 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
core/src/components/router/test/guards/index.html
View File

@ -113,18 +113,15 @@
</ion-list-header>
<ion-item>
<ion-label>Allow Navigation</ion-label>
<ion-radio value="allow"></ion-radio>
<ion-radio value="allow">Allow Navigation</ion-radio>
</ion-item>
<ion-item>
<ion-label>Block Navigation</ion-label>
<ion-radio value="block"></ion-radio>
<ion-radio value="block">Block Navigation</ion-radio>
</ion-item>
<ion-item>
<ion-label>Redirect</ion-label>
<ion-radio value="redirect"></ion-radio>
<ion-radio value="redirect">Redirect</ion-radio>
</ion-item>
</ion-radio-group>
@ -136,18 +133,15 @@
</ion-list-header>
<ion-item>
<ion-label>Allow Navigation</ion-label>
<ion-radio value="allow"></ion-radio>
<ion-radio value="allow">Allow Navigation</ion-radio>
</ion-item>
<ion-item>
<ion-label>Block Navigation</ion-label>
<ion-radio value="block"></ion-radio>
<ion-radio value="block">Block Navigation</ion-radio>
</ion-item>
<ion-item>
<ion-label>Redirect</ion-label>
<ion-radio value="redirect"></ion-radio>
<ion-radio value="redirect">Redirect</ion-radio>
</ion-item>
</ion-radio-group>
</div>