From beb45c17e8b851e73ea20723ab933c74a22c898b Mon Sep 17 00:00:00 2001 From: Adam Bradley Date: Sat, 22 Nov 2014 23:21:31 -0600 Subject: [PATCH] chore($ionicSlideBoxDelegate): deprecated methods --- js/angular/controller/slideBoxController.js | 18 ++++++++++-------- js/angular/service/slideBoxDelegate.js | 9 +++++++++ js/angular/service/viewService.js | 2 +- 3 files changed, 20 insertions(+), 9 deletions(-) diff --git a/js/angular/controller/slideBoxController.js b/js/angular/controller/slideBoxController.js index a085c334df..f1e62d6112 100644 --- a/js/angular/controller/slideBoxController.js +++ b/js/angular/controller/slideBoxController.js @@ -6,7 +6,8 @@ IonicModule '$interval', '$rootScope', '$timeout', -function(scope, element, $$ionicAttachDrag, $interval, $rootScope, $timeout) { + '$log', +function(scope, element, $$ionicAttachDrag, $interval, $rootScope, $timeout, $log) { var self = this; var relevantSlides = { @@ -66,30 +67,30 @@ function(scope, element, $$ionicAttachDrag, $interval, $rootScope, $timeout) { self.onDrag = onDrag; self.onDragEnd = onDragEnd; - /** DEPRECATED METHODS **/ + // DEPRECATED, as of v1.0.0-beta14 ------- self.update = deprecated.method( '$ionicSlideBoxDelegate.update() has been deprecated! Slidebox updates on its own now.', - console.warn, + $log.warn, angular.noop ); self.currentIndex = deprecated.method( '$ionicSlideBoxDelegate.currentIndex() has been deprecated! Use self.selected() instead.', - console.warn, + $log.warn, self.selected ); self.slide = deprecated.method( '$ionicSlideBoxDelegate.slide(newIndex[, speed]) has been deprecated! Use self.select(newIndex[, speed]) instead.', - console.warn, + $log.warn, self.select ); self.slidesCount = deprecated.method( '$ionicSlideBoxDelegate.slidesCount has been deprecated! Use self.slidesCount() instead.', - console.warn, + $log.warn, self.count ); self.stop = deprecated.method( '$ionicSlideBoxDelegate.stop() has been deprecated! Use $ionicSlideBoxDelegate.autoPlay(0) to stop instead.', - console.warn, + $log.warn, function() { self._stoppedInterval = self.autoPlayInterval; self.autoPlay(0); @@ -97,11 +98,12 @@ function(scope, element, $$ionicAttachDrag, $interval, $rootScope, $timeout) { ); self.start = deprecated.method( '$ionicSlideBoxDelegate.start() has been deprecated! Use $ionicSlideBoxDelegate.autoPlay(newInterval) to start instead.', - console.warn, + $log.warn, function() { self.autoPlay(self._stoppedInterval); } ); + // END DEPRECATED ------- // *** diff --git a/js/angular/service/slideBoxDelegate.js b/js/angular/service/slideBoxDelegate.js index 1878c77a80..16c81f3d1a 100644 --- a/js/angular/service/slideBoxDelegate.js +++ b/js/angular/service/slideBoxDelegate.js @@ -99,5 +99,14 @@ IonicModule * * Example: `$ionicSlideBoxDelegate.$getByHandle('my-handle').select(0);` */ + + // DEPRECATED, as of v1.0.0-beta14 ------- + 'update', + 'currentIndex', + 'slide', + 'slidesCount', + 'stop', + 'start' + // END DEPRECATED ------- ])); diff --git a/js/angular/service/viewService.js b/js/angular/service/viewService.js index 072c229fdb..dfeffc72c6 100644 --- a/js/angular/service/viewService.js +++ b/js/angular/service/viewService.js @@ -1,6 +1,6 @@ /** * @private - * DEPRECATED + * DEPRECATED, as of v1.0.0-beta14 ------- */ IonicModule .factory('$ionicViewService', ['$ionicHistory', '$log', function($ionicHistory, $log) {