mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-08-18 03:00:58 +08:00
chore(ci): core build caches api.txt (#27167)
<!-- Please refer to our contributing documentation for any questions on submitting a pull request, or let us know here if you need any help: https://ionicframework.com/docs/building/contributing --> <!-- Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation for details. --> <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> <!-- Issues are required for both bug fixes and features. --> Unbuilt changes in `core` are not always being caught because the `api.txt` file is not cached. Stencil will potentially update both the `src/components.d.ts` and `api.txt` files when there are built changes to the public API. We need to check both files when accounting for unbuilt changes. Example: https://github.com/ionic-team/ionic-framework/pull/25858 This had updates to `api.txt` that were not built. Built changes PR: https://github.com/ionic-team/ionic-framework/pull/25933 Example of this change catching `api.txt` changes as intended: https://github.com/ionic-team/ionic-framework/pull/27165 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - GitHub Actions core build step caches `api.txt` ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
This commit is contained in:
@ -22,4 +22,4 @@ runs:
|
||||
with:
|
||||
name: ionic-core
|
||||
output: core/CoreBuild.zip
|
||||
paths: core/dist core/components core/css core/hydrate core/loader core/src/components.d.ts
|
||||
paths: core/dist core/components core/css core/hydrate core/loader core/src/components.d.ts core/api.txt
|
||||
|
Reference in New Issue
Block a user