javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 12:29:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(modal): fix enter animation when the initial breakpoint value is less than the backdrop breakpoint (#29955)

Browse Source 
Issue number: internal

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
This PR aims to fix an issue introduced in
https://github.com/ionic-team/ionic-framework/pull/29932 where the enter
animation for ionic theme was in a broken state when the modal's initial
breakpoint value was lesser than the specified backdrop breakpoint.

## What is the new behavior?
- The erroneous behaviour happened because the shouldShowBackdrop
constant had a false value which was being taken into consideration when
computing the backdrop opacity for the ionic theme. This PR fixes this
by always transitioning the backdrop opacity from 0 to 0.7 once the
modal appears, independently of the initial, current or activation
breakpoint.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
This commit is contained in:
Pedro Lourenço
2024-10-22 16:03:11 +01:00
committed by GitHub
parent 2d2b081f19
commit bdb7cd6a21
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/src/components/modal/animations/sheet.ts
View File

@ -12,9 +12,12 @@ export const createSheetEnterAnimation = (opts: ModalAnimationOptions) => {
* current breakpoint, then the backdrop should be fading in. * current breakpoint, then the backdrop should be fading in.
*/ */
const shouldShowBackdrop = backdropBreakpoint === undefined || backdropBreakpoint < currentBreakpoint!; const shouldShowBackdrop = backdropBreakpoint === undefined || backdropBreakpoint < currentBreakpoint!;
const initialBackdrop = shouldShowBackdrop let initialBackdrop = '0';
? `calc(var(--backdrop-opacity) * ${staticBackdropOpacity ? 1 : currentBreakpoint!})` if (staticBackdropOpacity) {
: '0'; initialBackdrop = 'calc(var(--backdrop-opacity)';
} else if (shouldShowBackdrop) {
initialBackdrop = `calc(var(--backdrop-opacity) * ${currentBreakpoint!})`;
}
const backdropAnimation = createAnimation('backdropAnimation').fromTo('opacity', 0, initialBackdrop); const backdropAnimation = createAnimation('backdropAnimation').fromTo('opacity', 0, initialBackdrop);

2
core/src/components/modal/modal.tsx
View File

@ -1049,6 +1049,8 @@ interface ModalOverlayOptions {
/** /**
* The point after which the backdrop will begin * The point after which the backdrop will begin
* to fade in when using a sheet modal. * to fade in when using a sheet modal.
* This option is ignored for the ionic theme
* due to the option below.
*/ */
backdropBreakpoint: number; backdropBreakpoint: number;
/** /**