From bcae5a78474fa34b6da4216df45501a1de5f46bb Mon Sep 17 00:00:00 2001
From: Ken Sodemann <ken@ionic.io>
Date: Thu, 9 Nov 2017 11:58:02 -0600
Subject: [PATCH] feat(snapshot): add better reporting

---
 packages/core/scripts/Snapshot.js        | 13 ++++++++++++-
 packages/core/scripts/e2e-test-runner.js |  5 ++++-
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/packages/core/scripts/Snapshot.js b/packages/core/scripts/Snapshot.js
index 4737f0d8f2..aa00fc84bd 100644
--- a/packages/core/scripts/Snapshot.js
+++ b/packages/core/scripts/Snapshot.js
@@ -7,7 +7,6 @@ class Snapshot {
     this.appId = (options && options.appId) || 'test_app';
     this.domain = (options && options.domain) || 'localhost:8080';
     this.groupId = (options && options.groupId) || 'test_group';
-    this.testId = options && options.testId;
     this.sleepTime = (options && options.sleepBetweenSpecs) || 500;
     this.totalSpecs = options && options.totalSpecs;
     this.accessKey = options && options.accessKey;
@@ -22,6 +21,17 @@ class Snapshot {
     this.height =
       (options && options.platformDefaults && options.platformDefaults.params && options.platformDefaults.params.height) || -1;
 
+    this.start(options && options.testId);
+  }
+
+  async finish() {
+    console.log('waiting for uploads to complete');
+    await Promise.all(this.queue);
+    console.log(`done processing ${this.queue.length} screenshots`);
+  }
+
+  start(testId) {
+    this.testId = testId;
     this.queue = [];
     this.highestMismatch = 0;
     this.mismatches = [];
@@ -65,6 +75,7 @@ class Snapshot {
             this.mismatches.push(resultKey);
           }
         }
+        resolve(res);
       });
     });
     this.queue.push(p);
diff --git a/packages/core/scripts/e2e-test-runner.js b/packages/core/scripts/e2e-test-runner.js
index 817c8e97b8..0bd62f56ec 100644
--- a/packages/core/scripts/e2e-test-runner.js
+++ b/packages/core/scripts/e2e-test-runner.js
@@ -94,7 +94,7 @@ async function run() {
       testId: generateTestId(),
       domain: 'ionic-snapshot-go.appspot.com',
       // domain: 'localhost:8080',
-      sleepBetweenSpecs: 300,
+      sleepBetweenSpecs: 750,
       totalSpecs: getTotalTests(mocha.suite),
       platformDefaults: {
         browser: 'chrome',
@@ -114,6 +114,9 @@ async function run() {
       process.on('exit', function() {
         process.exit(failures); // exit with non-zero status if there were failures
       });
+      if (takeScreenshots) {
+        snapshot.finish();
+      }
       devServer.close();
       driver.quit();
     });