From bb62023a0cdc5a64e956766c7d1704797fc8c9ae Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Thu, 7 May 2020 16:33:51 -0400 Subject: [PATCH] fix(all): overlay components no longer display outline when focused (#21226) --- core/src/components/action-sheet/action-sheet.scss | 4 +++- core/src/components/alert/alert.scss | 2 ++ core/src/components/loading/loading.scss | 4 +++- core/src/components/modal/modal.scss | 4 +++- core/src/components/picker/picker.scss | 2 ++ core/src/components/popover/popover.scss | 2 ++ core/src/components/toast/toast.scss | 2 ++ 7 files changed, 17 insertions(+), 3 deletions(-) diff --git a/core/src/components/action-sheet/action-sheet.scss b/core/src/components/action-sheet/action-sheet.scss index 227a182c92..0242a63265 100644 --- a/core/src/components/action-sheet/action-sheet.scss +++ b/core/src/components/action-sheet/action-sheet.scss @@ -52,6 +52,8 @@ display: block; position: fixed; + outline: none; + font-family: $font-family-base; touch-action: none; @@ -210,4 +212,4 @@ opacity: var(--button-background-hover-opacity); } } -} \ No newline at end of file +} diff --git a/core/src/components/alert/alert.scss b/core/src/components/alert/alert.scss index 99f254e35d..8881d666e3 100644 --- a/core/src/components/alert/alert.scss +++ b/core/src/components/alert/alert.scss @@ -32,6 +32,8 @@ align-items: center; justify-content: center; + outline: none; + font-family: $font-family-base; contain: strict; diff --git a/core/src/components/loading/loading.scss b/core/src/components/loading/loading.scss index d95f3175d6..bb5d42de5b 100644 --- a/core/src/components/loading/loading.scss +++ b/core/src/components/loading/loading.scss @@ -33,6 +33,8 @@ align-items: center; justify-content: center; + outline: none; + font-family: $font-family-base; contain: strict; @@ -72,4 +74,4 @@ .spinner-crescent, .spinner-dots { color: var(--spinner-color); -} \ No newline at end of file +} diff --git a/core/src/components/modal/modal.scss b/core/src/components/modal/modal.scss index 581de3e0a4..c0b84be815 100644 --- a/core/src/components/modal/modal.scss +++ b/core/src/components/modal/modal.scss @@ -45,6 +45,8 @@ align-items: center; justify-content: center; + outline: none; + contain: strict; } @@ -77,7 +79,7 @@ .modal-shadow { position: absolute; - + background: transparent; } diff --git a/core/src/components/picker/picker.scss b/core/src/components/picker/picker.scss index 4c05c82092..ea082b73b0 100644 --- a/core/src/components/picker/picker.scss +++ b/core/src/components/picker/picker.scss @@ -40,6 +40,8 @@ width: 100%; height: 100%; + outline: none; + font-family: $font-family-base; contain: strict; diff --git a/core/src/components/popover/popover.scss b/core/src/components/popover/popover.scss index 13f9e7d621..f538505f35 100644 --- a/core/src/components/popover/popover.scss +++ b/core/src/components/popover/popover.scss @@ -32,6 +32,8 @@ align-items: center; justify-content: center; + outline: none; + color: $popover-text-color; z-index: $z-index-overlay; diff --git a/core/src/components/toast/toast.scss b/core/src/components/toast/toast.scss index 5158e8e0ba..94d08d3cfe 100644 --- a/core/src/components/toast/toast.scss +++ b/core/src/components/toast/toast.scss @@ -49,6 +49,8 @@ width: 100%; height: 100%; + outline: none; + color: var(--color); font-family: $font-family-base;