mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-11-08 07:41:51 +08:00
feat(input): add outline appearance for stacked label to ionic theme (#29268)
Issue number: Internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> All changes are specific to the `ionic` theme. - Styles added for `fill="outline"` plus `labelPlacement="stacked"`. - Markup rearranged slightly to ensure label sits above outline while still being clickable to focus the input. See code comments for details. - The default `labelPlacement` is now `"stacked"`. - Values for `labelPlacement` besides `"stacked"` and `"floating"` cannot be used. Note that per the ticket, I did not account for any other scope, including styles for helper text, `labelPlacement="floating"`, `shape="round"`, etc. This means that some states will look broken for now, and will be addressed in future tickets. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com> Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
This commit is contained in:
@ -1,9 +1,14 @@
|
||||
@import "./input";
|
||||
@import "./input.ionic.vars";
|
||||
@import "./input.ionic.outline.scss";
|
||||
|
||||
// Ionic Input
|
||||
// --------------------------------------------------
|
||||
|
||||
:host {
|
||||
--border-width: #{$ionic-border-size-small};
|
||||
--border-color: #{$ionic-color-neutral-300};
|
||||
|
||||
// TODO(FW-6113): Verify the ionic design token is correct once it's available and remove the hardcoded value.
|
||||
--highlight-color-invalid: var(--ionic-color-error-600, #970606);
|
||||
}
|
||||
@ -11,7 +16,7 @@
|
||||
// Ionic Input Sizes
|
||||
// --------------------------------------------------
|
||||
|
||||
:host(.input-size-large) {
|
||||
:host(.input-size-large) .native-wrapper {
|
||||
min-height: 48px;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user