From bb49c9f114f9bb7a714a18bfcdc257084b18ba8a Mon Sep 17 00:00:00 2001 From: jbavari Date: Tue, 13 Oct 2015 11:56:53 -0600 Subject: [PATCH] Updating search-bar basic demo to show the detectchanges from angular firing 1000's of times --- ionic/components/search-bar/search-bar.ts | 1 + ionic/components/search-bar/test/basic/index.ts | 11 +++++++---- ionic/components/search-bar/test/basic/main.html | 8 ++++---- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/ionic/components/search-bar/search-bar.ts b/ionic/components/search-bar/search-bar.ts index 3ab68fb26b..d0010a6024 100644 --- a/ionic/components/search-bar/search-bar.ts +++ b/ionic/components/search-bar/search-bar.ts @@ -92,6 +92,7 @@ export class SearchBar extends Ion { } inputChanged(event) { + console.log('input changed'); this.writeValue(event.target.value); this.onChange(event.target.value); } diff --git a/ionic/components/search-bar/test/basic/index.ts b/ionic/components/search-bar/test/basic/index.ts index dae68cf5fa..f45fc52ed5 100644 --- a/ionic/components/search-bar/test/basic/index.ts +++ b/ionic/components/search-bar/test/basic/index.ts @@ -17,9 +17,7 @@ function randomTitle() { class IonicApp { constructor() { var fb = new FormBuilder(); - this.form = fb.group({ - searchQuery: ['', Validators.required] - }); + this.searchQuery = ''; this.items = [] for(let i = 0; i < 100; i++) { @@ -29,8 +27,13 @@ class IonicApp { } } + doThis() { + console.log('Doing this'); + } + getItems() { - var q = this.form.controls.searchQuery.value; + var q = this.searchQuery; + console.log('Its changing'); if(q.trim() == '') { return this.items; } diff --git a/ionic/components/search-bar/test/basic/main.html b/ionic/components/search-bar/test/basic/main.html index cc77460287..c159ef0791 100644 --- a/ionic/components/search-bar/test/basic/main.html +++ b/ionic/components/search-bar/test/basic/main.html @@ -2,15 +2,15 @@ -
+ - + - + {{item.title}} -
+