From ba9327979aa4f344d1459b62b7968c4220326653 Mon Sep 17 00:00:00 2001 From: "Manu Mtz.-Almeida" Date: Sat, 3 Feb 2018 08:30:24 +0100 Subject: [PATCH] fix(virtual-scroll): cards e2e --- .../src/components/virtual-scroll/readme.md | 2 +- .../components/virtual-scroll/test/cards.html | 17 +---------------- .../virtual-scroll/virtual-scroll.tsx | 2 +- 3 files changed, 3 insertions(+), 18 deletions(-) diff --git a/packages/core/src/components/virtual-scroll/readme.md b/packages/core/src/components/virtual-scroll/readme.md index 704909ea17..b4161a62b0 100644 --- a/packages/core/src/components/virtual-scroll/readme.md +++ b/packages/core/src/components/virtual-scroll/readme.md @@ -1,4 +1,4 @@ -#ion-virtual-scroll +# ion-virtual-scroll Virtual Scroll displays a virtual, "infinite" list. An array of records is passed to the virtual scroll containing the data to create templates diff --git a/packages/core/src/components/virtual-scroll/test/cards.html b/packages/core/src/components/virtual-scroll/test/cards.html index 823a244426..4434c4e81c 100644 --- a/packages/core/src/components/virtual-scroll/test/cards.html +++ b/packages/core/src/components/virtual-scroll/test/cards.html @@ -65,27 +65,12 @@ if (cell.type === 0) return renderItem(el, cell.value); return renderHeader(el, cell.value); }; - - - function getImgSrc() { - let src = images[rotateImg]; - rotateImg++; - if (rotateImg === images.length) rotateImg = 0; - return src; - } - - let rotateImg = 0; - + const lorem = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'; const items = []; for (var i = 0; i < 1000; i++) { items.push({ - name: i + ' - ' + images[rotateImg], - imgSrc: getImgSrc(), - avatarSrc: getImgSrc(), - imgHeight: Math.floor((Math.random() * 50) + 150), content: lorem.substring(0, (Math.random() * (lorem.length - 100)) + 100) }); - rotateImg++; } virtual.items = items; }; diff --git a/packages/core/src/components/virtual-scroll/virtual-scroll.tsx b/packages/core/src/components/virtual-scroll/virtual-scroll.tsx index c5aacd0f2f..7ccbb2b22b 100644 --- a/packages/core/src/components/virtual-scroll/virtual-scroll.tsx +++ b/packages/core/src/components/virtual-scroll/virtual-scroll.tsx @@ -12,7 +12,7 @@ import { Cell, DomRenderFn, HeaderFn, ItemHeightFn, ItemRenderFn, NodeHeightFn, export class VirtualScroll { private scrollEl: HTMLElement; - private range: Range; + private range: Range = {offset: 0, length: 0}; private timerUpdate: any; private heightIndex: Uint32Array; private viewportHeight: number;