javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-16 18:17:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(all): strict boolean conditions

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-08-31 18:59:09 +02:00
parent f383ebdf13
commit ba2230510e
96 changed files with 990 additions and 962 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
core/src/components/select/select.tsx
View File

@ -86,7 +86,7 @@ export class Select {
/**
* the value of the select.
*/
@Prop({ mutable: true }) value?: any;
@Prop({ mutable: true }) value?: any | null;
/**
* Emitted when the value has changed.
@ -314,6 +314,7 @@ export class Select {
disabled: o.disabled,
handler: () => {
this.value = o.value;
// tslint:disable-next-line:no-floating-promises
this.close();
}
} as SelectPopoverOption;
@ -410,10 +411,10 @@ export class Select {
/**
* Close the select interface.
*/
private close(): Promise<void> {
private close(): Promise<boolean> {
// TODO check !this.overlay || !this.isFocus()
if (!this.overlay) {
return Promise.resolve();
return Promise.resolve(false);
}
const overlay = this.overlay;
@ -440,7 +441,7 @@ export class Select {
if (Array.isArray(this.value)) {
return this.value.length > 0;
}
return (this.value !== null && this.value !== undefined && this.value !== '');
return (this.value != null && this.value !== undefined && this.value !== '');
}
private emitStyle() {
@ -469,7 +470,7 @@ export class Select {
let addPlaceholderClass = false;
let selectText = this.selectedText || this.text;
if (!selectText && this.placeholder) {
if (selectText === undefined && this.placeholder) {
selectText = this.placeholder;
addPlaceholderClass = true;
}