javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 12:29:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(all): strict boolean conditions

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-08-31 18:59:09 +02:00
parent f383ebdf13
commit ba2230510e
96 changed files with 990 additions and 962 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
core/src/components/picker-column/picker-column.tsx
View File

@ -58,9 +58,9 @@ export class PickerColumnCmp {
gestureName: 'picker-swipe',
gesturePriority: 100,
threshold: 0,
onStart: this.onStart.bind(this),
onMove: this.onMove.bind(this),
onEnd: this.onEnd.bind(this),
onStart: ev => this.onStart(ev),
onMove: ev => this.onMove(ev),
onEnd: ev => this.onEnd(ev),
});
this.gesture.setDisabled(false);
}
@ -204,10 +204,8 @@ export class PickerColumnCmp {
// We have to prevent default in order to block scrolling under the picker
// but we DO NOT have to stop propagation, since we still want
// some "click" events to capture
if (detail.event) {
detail.event.preventDefault();
detail.event.stopPropagation();
}
detail.event.preventDefault();
detail.event.stopPropagation();
// reset everything
cancelAnimationFrame(this.rafId);
@ -226,10 +224,8 @@ export class PickerColumnCmp {
}
private onMove(detail: GestureDetail) {
if (detail.event) {
detail.event.preventDefault();
detail.event.stopPropagation();
}
detail.event.preventDefault();
detail.event.stopPropagation();
// update the scroll position relative to pointer start position
let y = this.y + detail.deltaY;