javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 12:29:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(all): strict boolean conditions

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-08-31 18:59:09 +02:00
parent f383ebdf13
commit ba2230510e
96 changed files with 990 additions and 962 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
core/src/components/modal/modal.tsx
View File

@ -127,12 +127,12 @@ export class Modal implements OverlayInterface {
ev.stopPropagation();
ev.preventDefault();
this.dismiss();
return this.dismiss();
}
@Listen('ionBackdropTap')
protected onBackdropTap() {
this.dismiss(null, BACKDROP);
return this.dismiss(null, BACKDROP);
}
@Listen('ionModalDidPresent')
@ -177,9 +177,12 @@ export class Modal implements OverlayInterface {
* Dismiss the modal overlay after it has been presented.
*/
@Method()
async dismiss(data?: any, role?: string): Promise<void> {
await dismiss(this, data, role, 'modalLeave', iosLeaveAnimation, mdLeaveAnimation);
await detachComponent(this.delegate, this.usersElement);
async dismiss(data?: any, role?: string): Promise<boolean> {
const dismissed = await dismiss(this, data, role, 'modalLeave', iosLeaveAnimation, mdLeaveAnimation);
if (dismissed) {
await detachComponent(this.delegate, this.usersElement);
}
return dismissed;
}
/**