javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 12:29:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(all): strict boolean conditions

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-08-31 18:59:09 +02:00
parent f383ebdf13
commit ba2230510e
96 changed files with 990 additions and 962 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
core/src/components/loading/loading.tsx
View File

@ -63,7 +63,7 @@ export class Loading implements OverlayInterface {
/**
* Number of milliseconds to wait before dismissing the loading indicator.
*/
@Prop() duration?: number;
@Prop() duration = 0;
/**
* If true, the loading indicator will be dismissed when the backdrop is clicked. Defaults to `false`.
@ -122,7 +122,7 @@ export class Loading implements OverlayInterface {
@Event({ eventName: 'ionLoadingDidDismiss' }) didDismiss!: EventEmitter<OverlayEventDetail>;
componentWillLoad() {
if (!this.spinner) {
if (this.spinner === undefined) {
this.spinner = this.config.get('loadingSpinner', this.mode === 'ios' ? 'lines' : 'crescent');
}
}
@ -137,7 +137,7 @@ export class Loading implements OverlayInterface {
@Listen('ionBackdropTap')
protected onBackdropTap() {
this.dismiss(null, BACKDROP);
return this.dismiss(null, BACKDROP);
}
/**
@ -147,7 +147,7 @@ export class Loading implements OverlayInterface {
async present(): Promise<void> {
await present(this, 'loadingEnter', iosEnterAnimation, mdEnterAnimation, undefined);
if (this.duration) {
if (this.duration > 0) {
this.durationTimeout = setTimeout(
() => this.dismiss(),
this.duration + 10
@ -159,7 +159,7 @@ export class Loading implements OverlayInterface {
* Dismiss the loading overlay after it has been presented.
*/
@Method()
dismiss(data?: any, role?: string): Promise<void> {
dismiss(data?: any, role?: string): Promise<boolean> {
if (this.durationTimeout) {
clearTimeout(this.durationTimeout);
}