javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-19 03:32:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix(segment): Change for loops to be forEach

Browse Source
This commit is contained in:
jbavari
2015-10-16 13:19:42 -06:00
parent 28b7332e2f
commit b93aae4940
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
ionic/components/segment/segment.ts
View File

@ -80,13 +80,11 @@ export class Segment extends Ion {
if (this.buttons.length == 0) { if (this.buttons.length == 0) {
return; return;
} }
//for(let button of this.buttons) { this.buttons.forEach(function(button) {
for(var i = 0, j = this.buttons.length; i < j; i++) {
var button = this.buttons[i];
if(button.value === value) { if(button.value === value) {
button.isActive = true; button.isActive = true;
} }
} });
} }
/** /**
@ -94,11 +92,9 @@ export class Segment extends Ion {
* @param {SegmentButton} segmentButton The button to select. * @param {SegmentButton} segmentButton The button to select.
*/ */
selected(segmentButton) { selected(segmentButton) {
//for(let button of this.buttons) { this.buttons.forEach(function(button) {
for(var i = 0, j = this.buttons.length; i < j; i++) {
let button = this.buttons[i];
button.isActive = false; button.isActive = false;
} });
segmentButton.isActive = true; segmentButton.isActive = true;
//this.onChange(); //this.onChange();