From b85b7c6b9ddde03b77812e443dff48843bb5cefd Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Wed, 12 Jun 2019 11:41:26 -0400 Subject: [PATCH] fix(test): rsolve race conditions with toast and item --- core/src/components/item/test/inputs/e2e.ts | 9 ++++++--- core/src/components/toast/test/test.utils.ts | 6 ++++-- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/core/src/components/item/test/inputs/e2e.ts b/core/src/components/item/test/inputs/e2e.ts index 6775677cf7..971e1dc41d 100644 --- a/core/src/components/item/test/inputs/e2e.ts +++ b/core/src/components/item/test/inputs/e2e.ts @@ -15,8 +15,10 @@ test('item: inputs', async () => { expect(compare).toMatchScreenshot(); // Disable everything - await page.click('#btnDisabled'); - await page.waitFor(500); + const disableToggle = await page.find('#btnDisabled'); + await disableToggle.waitForVisible(); + await disableToggle.click(); + await page.waitFor(100); // check form await page.click('#submit'); @@ -28,7 +30,7 @@ test('item: inputs', async () => { expect(compare).toMatchScreenshot(); // Reenable and set some value - await page.click('#btnDisabled'); + await disableToggle.click(); await page.click('#btnSomeValue'); await page.waitFor(100); @@ -64,5 +66,6 @@ test('item: inputs', async () => { async function checkFormResult(page: E2EPage, content: string) { const div = await page.find('#form-result'); + expect(div.textContent).toEqual(content); } diff --git a/core/src/components/toast/test/test.utils.ts b/core/src/components/toast/test/test.utils.ts index b7df07e3a3..918a2d71b0 100644 --- a/core/src/components/toast/test/test.utils.ts +++ b/core/src/components/toast/test/test.utils.ts @@ -16,10 +16,12 @@ export async function testToast( const screenshotCompares = []; - await page.click(selector); - await page.waitForSelector(selector); + const button = await page.find(selector); + await button.waitForVisible(); + await button.click(); let toast = await page.find('ion-toast'); + await toast.waitForVisible(); expect(toast).not.toBe(null); await toast.waitForVisible();