From b8553d89f84970db452646ad7a88e2fc0fd88657 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Mon, 31 Jul 2023 11:25:45 -0400 Subject: [PATCH] docs(popover): clarify size property (#27894) Issue number: N/A --------- ## What is the current behavior? See: https://github.com/ionic-team/ionic-framework/issues/27877 The current description does not accurately describe what `size="auto"` does. ## What is the new behavior? - Description clarifies that the width of the popover is set based on platform defaults. ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information --- core/src/components.d.ts | 4 ++-- core/src/components/popover/popover.tsx | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/core/src/components.d.ts b/core/src/components.d.ts index 0b839d4ee7..7a0c2638ba 100644 --- a/core/src/components.d.ts +++ b/core/src/components.d.ts @@ -2176,7 +2176,7 @@ export namespace Components { */ "side": PositionSide; /** - * Describes how to calculate the popover width. If `"cover"`, the popover width will match the width of the trigger. If `"auto"`, the popover width will be determined by the content in the popover. + * Describes how to calculate the popover width. If `"cover"`, the popover width will match the width of the trigger. If `"auto"`, the popover width will be set to a static default value. */ "size": PopoverSize; /** @@ -6189,7 +6189,7 @@ declare namespace LocalJSX { */ "side"?: PositionSide; /** - * Describes how to calculate the popover width. If `"cover"`, the popover width will match the width of the trigger. If `"auto"`, the popover width will be determined by the content in the popover. + * Describes how to calculate the popover width. If `"cover"`, the popover width will match the width of the trigger. If `"auto"`, the popover width will be set to a static default value. */ "size"?: PopoverSize; /** diff --git a/core/src/components/popover/popover.tsx b/core/src/components/popover/popover.tsx index bccd795fe7..d32856eedb 100644 --- a/core/src/components/popover/popover.tsx +++ b/core/src/components/popover/popover.tsx @@ -180,8 +180,7 @@ export class Popover implements ComponentInterface, PopoverInterface { /** * Describes how to calculate the popover width. * If `"cover"`, the popover width will match the width of the trigger. - * If `"auto"`, the popover width will be determined by the content in - * the popover. + * If `"auto"`, the popover width will be set to a static default value. */ @Prop() size: PopoverSize = 'auto';