octicon-mirror(24/)
javascript/ionic-framework
octicon-rss(16/)
1
0
octicon-repo-forked(16/)Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 22:44:13 +08:00
octicon-code(16/) Code octicon-issue-opened(16/) Issues octicon-package(16/) Packages octicon-project(16/) Projects octicon-tag(16/) Releases octicon-book(16/) Wiki octicon-pulse(16/) Activity

revert(): revert base components feature (#26692)

Browse Source 
The Ionic Framework team would like to re-evaluate our approach to improving customization options when building mobile applications. We are looking at other solutions that a) make customizing an app UI easier and b) are applicable to a broader set of developers.
This commit is contained in:
octicon-git-branch(16/)
octicon-tag(16/)
Liam DeBeasi
2023-01-30 11:52:36 -05:00
committed by GitHub
gitea-unlock(16/)
parent 592a4f1a37
commit b78b454e08
octicon-diff(16/tw-mr-1) 114 changed files with 387 additions and 1587 deletions
gitea-whitespace(16/)
gitea-split(16/)
octicon-kebab-horizontal(16/)
Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/components/tab-bar/tab-bar.scss
View File

@@ -1,5 +1,4 @@
@import "../../themes/ionic.globals";
@import "./tab-bar.vars.scss";
:host {
/**
@@ -16,7 +15,6 @@
justify-content: center;
width: auto;
height: $tab-bar-height;
padding-bottom: var(--ion-safe-area-bottom, 0);

6
core/src/components/tab-bar/tab-bar.tsx
View File

@@ -1,20 +1,18 @@
import type { ComponentInterface, EventEmitter } from '@stencil/core';
import { Component, Element, Event, Host, Prop, State, Watch, h } from '@stencil/core';
import { getIonStylesheet } from '../../global/ionic-global';
import { getIonMode } from '../../global/ionic-global';
import type { Color, TabBarChangedEventDetail } from '../../interface';
import type { KeyboardController } from '../../utils/keyboard/keyboard-controller';
import { createKeyboardController } from '../../utils/keyboard/keyboard-controller';
import { createColorClasses } from '../../utils/theme';
/**
* @virtualProp {true | false} useBase - useBase determines if base components is enabled.
* @virtualProp {"ios" | "md"} mode - The mode determines which platform styles to use.
*/
@Component({
tag: 'ion-tab-bar',
styleUrls: {
base: 'tab-bar.scss',
ios: 'tab-bar.ios.scss',
md: 'tab-bar.md.scss',
},
@@ -75,7 +73,7 @@ export class TabBar implements ComponentInterface {
render() {
const { color, translucent, keyboardVisible } = this;
const mode = getIonStylesheet(this);
const mode = getIonMode(this);
const shouldHide = keyboardVisible && this.el.getAttribute('slot') !== 'top';
return (

9
core/src/components/tab-bar/tab-bar.vars.scss
View File

@@ -1,9 +0,0 @@
// Base Tab Bar
// --------------------------------------------------
/// @prop - Default height of the tab bar.
/**
* We choose an explicit height otherwise the tab bar will
* appear to be hidden when using base components.
*/
$tab-bar-height: 50px !default;