javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 08:09:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

revert(): revert base components feature (#26692)

Browse Source 
The Ionic Framework team would like to re-evaluate our approach to improving customization options when building mobile applications. We are looking at other solutions that a) make customizing an app UI easier and b) are applicable to a broader set of developers.
This commit is contained in:
Liam DeBeasi
2023-01-30 11:52:36 -05:00
committed by GitHub
parent 592a4f1a37
commit b78b454e08
114 changed files with 387 additions and 1587 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/src/components/picker/picker.scss
View File

@ -30,8 +30,6 @@
--max-width: #{$picker-max-width};
--min-height: auto;
--max-height: auto;
--backdrop-opacity: 0;
--height: #{$picker-height};
@include font-smoothing();
@include position(0, null, null, 0);
@ -90,7 +88,6 @@
.picker-toolbar {
width: 100%;
height: $picker-toolbar-height;
background: transparent;
@ -120,8 +117,6 @@
justify-content: center;
height: $picker-height - $picker-toolbar-height;
margin-bottom: var(--ion-safe-area-bottom, 0);
contain: strict;

6
core/src/components/picker/picker.tsx
View File

@ -1,7 +1,7 @@
import type { ComponentInterface, EventEmitter } from '@stencil/core';
import { Component, Element, Event, Host, Method, Prop, State, Watch, h } from '@stencil/core';
import { getIonStylesheet } from '../../global/ionic-global';
import { getIonMode } from '../../global/ionic-global';
import type {
AnimationBuilder,
CssClassMap,
@ -30,13 +30,11 @@ import { iosLeaveAnimation } from './animations/ios.leave';
// TODO(FW-2832): types
/**
* @virtualProp {true | false} useBase - useBase determines if base components is enabled.
* @virtualProp {"ios" | "md"} mode - The mode determines which platform styles to use.
*/
@Component({
tag: 'ion-picker',
styleUrls: {
base: 'picker.scss',
ios: 'picker.ios.scss',
md: 'picker.md.scss',
},
@ -334,7 +332,7 @@ export class Picker implements ComponentInterface, OverlayInterface {
render() {
const { htmlAttributes } = this;
const mode = getIonStylesheet(this);
const mode = getIonMode(this);
return (
<Host
aria-modal="true"

14
core/src/components/picker/picker.vars.scss
View File

@ -8,17 +8,3 @@ $picker-width: 100% !default;
/// @prop - Max width of the picker
$picker-max-width: 500px !default;
/// @prop - Height of the picker
/**
* We choose an explicit height otherwise the picker will
* appear to be hidden when using base components.
*/
$picker-height: 200px !default;
/// @prop - Height of the picker button toolbar
/**
* We choose an explicit height otherwise the toolbar will
* appear to be hidden when using base components.
*/
$picker-toolbar-height: 50px !default;