javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

revert(): revert base components feature (#26692)

Browse Source 
The Ionic Framework team would like to re-evaluate our approach to improving customization options when building mobile applications. We are looking at other solutions that a) make customizing an app UI easier and b) are applicable to a broader set of developers.
This commit is contained in:
Liam DeBeasi
2023-01-30 11:52:36 -05:00
committed by GitHub
parent 592a4f1a37
commit b78b454e08
114 changed files with 387 additions and 1587 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
core/src/components/input/input.tsx
View File

@ -5,7 +5,7 @@ import type { LegacyFormController } from '@utils/forms';
import { printIonWarning } from '@utils/logging';
import { closeCircle, closeSharp } from 'ionicons/icons';
import { getIonStylesheet, getIonBehavior } from '../../global/ionic-global';
import { getIonMode } from '../../global/ionic-global';
import type {
AutocompleteTypes,
Color,
@ -21,13 +21,11 @@ import { createColorClasses, hostContext } from '../../utils/theme';
import { getCounterText } from './input.utils';
/**
* @virtualProp {true | false} useBase - useBase determines if base components is enabled.
* @virtualProp {"ios" | "md"} mode - The mode determines which platform styles to use.
*/
@Component({
tag: 'ion-input',
styleUrls: {
base: 'input.scss',
ios: 'input.ios.scss',
md: 'input.md.scss',
},
@ -604,8 +602,8 @@ export class Input implements ComponentInterface {
* when fill="outline".
*/
private renderLabelContainer() {
const platform = getIonBehavior(this);
const hasOutlineFill = platform === 'md' && this.fill === 'outline';
const mode = getIonMode(this);
const hasOutlineFill = mode === 'md' && this.fill === 'outline';
if (hasOutlineFill) {
/**
@ -638,7 +636,7 @@ export class Input implements ComponentInterface {
private renderInput() {
const { disabled, fill, readonly, shape, inputId, labelPlacement } = this;
const mode = getIonStylesheet(this);
const mode = getIonMode(this);
const value = this.getValue();
const inItem = hostContext('ion-item', this.el);
const shouldRenderHighlight = mode === 'md' && fill !== 'outline' && !inItem;
@ -744,7 +742,7 @@ Developers can dismiss this warning by removing their usage of the "legacy" prop
this.hasLoggedDeprecationWarning = true;
}
const mode = getIonStylesheet(this);
const mode = getIonMode(this);
const value = this.getValue();
const labelId = this.inputId + '-lbl';
const label = findItemLabel(this.el);