octicon-rss(16/)
You've already forked ionic-framework
mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-11-10 22:44:13 +08:00
fix(angular): fix controlValueAccessor for boolean
fixes #16371
This commit is contained in:
octicon-git-branch(16/)
octicon-tag(16/)
committed by
Manu MA
gitea-unlock(16/)
parent
359bdcf8ec
commit
b645bfd1b7
octicon-diff(16/tw-mr-1) 2 changed files with 9 additions and 4 deletions
@@ -1,7 +1,7 @@
|
||||
import { Directive, ElementRef, HostListener } from '@angular/core';
|
||||
import { NG_VALUE_ACCESSOR } from '@angular/forms';
|
||||
|
||||
import { ValueAccessor } from './value-accessor';
|
||||
import { ValueAccessor, setIonicClasses } from './value-accessor';
|
||||
|
||||
@Directive({
|
||||
/* tslint:disable-next-line:directive-selector */
|
||||
@@ -20,6 +20,11 @@ export class BooleanValueAccessor extends ValueAccessor {
|
||||
super(el);
|
||||
}
|
||||
|
||||
writeValue(value: any) {
|
||||
this.el.nativeElement.checked = this.lastValue = value == null ? '' : value;
|
||||
setIonicClasses(this.el);
|
||||
}
|
||||
|
||||
@HostListener('ionChange', ['$event.target.checked'])
|
||||
_handleIonChange(value: any) {
|
||||
this.handleChangeEvent(value);
|
||||
|
||||
@@ -5,9 +5,9 @@ export class ValueAccessor implements ControlValueAccessor {
|
||||
|
||||
private onChange: (value: any) => void = () => {/**/};
|
||||
private onTouched: () => void = () => {/**/};
|
||||
private lastValue: any;
|
||||
protected lastValue: any;
|
||||
|
||||
constructor(private el: ElementRef) {}
|
||||
constructor(protected el: ElementRef) {}
|
||||
|
||||
writeValue(value: any) {
|
||||
this.el.nativeElement.value = this.lastValue = value == null ? '' : value;
|
||||
@@ -41,7 +41,7 @@ export class ValueAccessor implements ControlValueAccessor {
|
||||
}
|
||||
}
|
||||
|
||||
function setIonicClasses(element: ElementRef) {
|
||||
export function setIonicClasses(element: ElementRef) {
|
||||
requestAnimationFrame(() => {
|
||||
const classList = (element.nativeElement as HTMLElement).classList;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user