javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-08 23:58:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(refresher-content): remove the aria-label (#28968)

Browse Source 
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
This commit is contained in:
Maria Hutt
2024-02-05 08:19:49 -08:00
committed by GitHub
parent f4d341cec2
commit b43b9ecfe0
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/src/components/refresher-content/refresher-content.tsx
View File

@ -114,7 +114,7 @@ export class RefresherContent implements ComponentInterface {
{this.pullingIcon && hasSpinner && ( {this.pullingIcon && hasSpinner && (
<div class="refresher-pulling-icon"> <div class="refresher-pulling-icon">
<div class="spinner-arrow-container"> <div class="spinner-arrow-container">
<ion-spinner name={this.pullingIcon as SpinnerTypes} aria-label="pulling icon" paused></ion-spinner> <ion-spinner name={this.pullingIcon as SpinnerTypes} paused></ion-spinner>
{mode === 'md' && this.pullingIcon === 'circular' && ( {mode === 'md' && this.pullingIcon === 'circular' && (
<div class="arrow-container"> <div class="arrow-container">
<ion-icon icon={caretBackSharp} aria-hidden="true"></ion-icon> <ion-icon icon={caretBackSharp} aria-hidden="true"></ion-icon>
@ -133,7 +133,7 @@ export class RefresherContent implements ComponentInterface {
<div class="refresher-refreshing"> <div class="refresher-refreshing">
{this.refreshingSpinner && ( {this.refreshingSpinner && (
<div class="refresher-refreshing-icon"> <div class="refresher-refreshing-icon">
<ion-spinner name={this.refreshingSpinner} aria-label="refreshing icon"></ion-spinner> <ion-spinner name={this.refreshingSpinner}></ion-spinner>
</div> </div>
)} )}
{this.refreshingText !== undefined && this.renderRefreshingText()} {this.refreshingText !== undefined && this.renderRefreshingText()}

3
core/src/components/refresher/test/a11y/refresher.e2e.ts
View File

@ -23,7 +23,8 @@ configs({ directions: ['ltr'], modes: ['md'], themes: ['light', 'dark'] }).forEa
await expect(refresher).toHaveClass(/refresher-pulling/); await expect(refresher).toHaveClass(/refresher-pulling/);
const results = await new AxeBuilder({ page }).analyze(); // TODO(FW-5937): Remove the disableRules once the ticket is resolved.
const results = await new AxeBuilder({ page }).disableRules('aria-progressbar-name').analyze();
expect(results.violations).toEqual([]); expect(results.violations).toEqual([]);
}); });