From b1c4c724745bd350cbf8b95c1e23f053dc8d6236 Mon Sep 17 00:00:00 2001
From: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Date: Mon, 29 Jan 2024 13:15:50 -0500
Subject: [PATCH] refactor(react, react-router): build works on windows
 (#28904)

Issue number: Internal
---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

React and React Router packages do not build correctly on Windows
because certain dependencies were not marked as external.
## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- 3rd party packages are correctly marked as external


## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
---
 packages/react-router/rollup.config.mjs | 3 ++-
 packages/react/rollup.config.mjs        | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/packages/react-router/rollup.config.mjs b/packages/react-router/rollup.config.mjs
index d9ccf1f4af..6647b5197a 100644
--- a/packages/react-router/rollup.config.mjs
+++ b/packages/react-router/rollup.config.mjs
@@ -1,4 +1,5 @@
 import typescript from '@rollup/plugin-typescript';
+const external = ['react', 'react-dom', 'react-router', 'react-router-dom', 'history', 'tslib'];
 
 export default {
   input: 'src/index.ts',
@@ -9,8 +10,8 @@ export default {
       sourcemap: true,
     }
   ],
-  external: (id) => !/^(\.|\/)/.test(id),
   plugins: [
     typescript(),
   ],
+  external: id => external.includes(id) || id.startsWith('@ionic/core') || id.startsWith('ionicons') || id.startsWith('@ionic/react'),
 };
diff --git a/packages/react/rollup.config.mjs b/packages/react/rollup.config.mjs
index 71f731bdf2..4a5ae0f419 100644
--- a/packages/react/rollup.config.mjs
+++ b/packages/react/rollup.config.mjs
@@ -1,4 +1,5 @@
 import typescript from '@rollup/plugin-typescript';
+const external = ['react', 'react-dom', 'react-router', 'react-router-dom', 'history', 'tslib'];
 
 export default {
   input: 'src/index.ts',
@@ -11,8 +12,8 @@ export default {
       sourcemap: true,
     }
   ],
-  external: (id) => !/^(\.|\/)/.test(id),
   plugins: [
     typescript(),
   ],
+  external: id => external.includes(id) || id.startsWith('@ionic/core') || id.startsWith('ionicons'),
 };