chore(angular): upgrade to official 18 release (#29571)

Issue number: internal

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Angular 18 test app was using an RC.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Updated to the official release.
- Removed the `--legacy-peer-deps` that is no longer needed

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

N/A

.github/workflows/actions/test-angular-e2e/action.yml

@@ -29,7 +29,7 @@ runs:
       shell: bash
       working-directory: ./packages/angular/test
     - name: Install Dependencies
-      run: npm install --legacy-peer-deps # TODO(FW-6227): Remove legacy-peer-deps flag
+      run: npm install
       shell: bash
       working-directory: ./packages/angular/test/build/${{ inputs.app }}
     - name: Sync Built Changes

packages/angular/test/apps/ng18/package.json

@@ -19,16 +19,16 @@
     "test.watch": "concurrently \"npm run start\" \"wait-on http-get://localhost:4200 && npm run cy.open\" --kill-others --success first"
   },
   "dependencies": {
-    "@angular/animations": "^18.0.0-rc.0",
+    "@angular/animations": "^18.0.0",
-    "@angular/common": "^18.0.0-rc.0",
+    "@angular/common": "^18.0.0",
-    "@angular/compiler": "^18.0.0-rc.0",
+    "@angular/compiler": "^18.0.0",
-    "@angular/core": "^18.0.0-rc.0",
+    "@angular/core": "^18.0.0",
-    "@angular/forms": "^18.0.0-rc.0",
+    "@angular/forms": "^18.0.0",
-    "@angular/platform-browser": "^18.0.0-rc.0",
+    "@angular/platform-browser": "^18.0.0",
-    "@angular/platform-browser-dynamic": "^18.0.0-rc.0",
+    "@angular/platform-browser-dynamic": "^18.0.0",
-    "@angular/platform-server": "^18.0.0-rc.0",
+    "@angular/platform-server": "^18.0.0",
-    "@angular/router": "^18.0.0-rc.0",
+    "@angular/router": "^18.0.0",
-    "@angular/ssr": "^18.0.0-rc.0",
+    "@angular/ssr": "^18.0.0",
     "@ionic/angular": "^8.0.0",
     "@ionic/angular-server": "^8.0.0",
     "core-js": "^3.33.2",
@@ -40,22 +40,22 @@
     "zone.js": "~0.14.2"
   },
   "devDependencies": {
-    "@angular-devkit/build-angular": "^18.0.0-rc.0",
+    "@angular-devkit/build-angular": "^18.0.0",
-    "@angular-eslint/builder": "^17.0.0",
+    "@angular-eslint/builder": "^18.0.0",
-    "@angular-eslint/eslint-plugin": "^17.0.0",
+    "@angular-eslint/eslint-plugin": "^18.0.0",
-    "@angular-eslint/eslint-plugin-template": "^17.0.0",
+    "@angular-eslint/eslint-plugin-template": "^18.0.0",
-    "@angular-eslint/schematics": "^17.0.0",
+    "@angular-eslint/schematics": "^18.0.0",
-    "@angular-eslint/template-parser": "^17.0.0",
+    "@angular-eslint/template-parser": "^18.0.0",
-    "@angular/cli": "^17.0.0",
+    "@angular/cli": "^18.0.0",
-    "@angular/compiler-cli": "^18.0.0-rc.0",
+    "@angular/compiler-cli": "^18.0.0",
-    "@angular/language-service": "^18.0.0-rc.0",
+    "@angular/language-service": "^18.0.0",
     "@types/express": "^4.17.7",
     "@types/ws": "8.5.3",
     "@typescript-eslint/eslint-plugin": "^6.0.0",
     "@typescript-eslint/parser": "^6.0.0",
     "concurrently": "^6.0.0",
     "cypress": "^13.2.0",
-    "eslint": "^7.26.0",
+    "eslint": "^8.57.0",
     "ts-loader": "^6.2.2",
     "ts-node": "^8.3.0",
     "typescript": "^5.4.0",

packages/angular/test/base/scripts/sync.sh

@@ -15,8 +15,7 @@ npm pack ../../../dist
 npm pack ../../../../angular-server/dist
 
 # Install Dependencies
-# TODO(FW-6227): Remove --legacy-peer-deps once Angular 18 is released
+npm install *.tgz --no-save
-npm install *.tgz --no-save --legacy-peer-deps
 
 # Delete Angular cache directory
 rm -rf .angular/