From b05eaeb85ba45eef0f23eccbeea302b86ea3b744 Mon Sep 17 00:00:00 2001 From: "Manu Mtz.-Almeida" Date: Tue, 20 Feb 2018 15:00:52 +0100 Subject: [PATCH] fix(backdrop): device support --- packages/core/src/components.d.ts | 4 +- .../components/action-sheet/action-sheet.scss | 2 + .../components/action-sheet/action-sheet.tsx | 11 +-- .../action-sheet/animations/ios.enter.ts | 2 +- .../action-sheet/animations/ios.leave.ts | 2 +- .../action-sheet/animations/md.enter.ts | 2 +- .../action-sheet/animations/md.leave.ts | 2 +- packages/core/src/components/alert/alert.scss | 2 + packages/core/src/components/alert/alert.tsx | 13 ++-- .../components/alert/animations/ios.enter.ts | 2 +- .../components/alert/animations/ios.leave.ts | 2 +- .../components/alert/animations/md.enter.ts | 2 +- .../components/alert/animations/md.leave.ts | 2 +- .../src/components/backdrop/backdrop.scss | 15 +++- .../core/src/components/backdrop/backdrop.tsx | 47 ++++++++++-- .../core/src/components/backdrop/readme.md | 31 ++++++-- .../loading/animations/ios.enter.ts | 2 +- .../loading/animations/ios.leave.ts | 2 +- .../components/loading/animations/md.enter.ts | 2 +- .../components/loading/animations/md.leave.ts | 2 +- .../src/components/loading/loading.ios.scss | 4 - .../components/loading/loading.ios.vars.scss | 3 - .../src/components/loading/loading.md.scss | 4 - .../components/loading/loading.md.vars.scss | 3 - .../core/src/components/loading/loading.scss | 26 +------ .../core/src/components/loading/loading.tsx | 20 ++--- packages/core/src/components/menu/menu.tsx | 10 ++- .../src/components/menu/test/basic/index.html | 17 +++++ .../components/modal/animations/ios.enter.ts | 2 +- .../components/modal/animations/ios.leave.ts | 2 +- .../components/modal/animations/md.enter.ts | 2 +- .../components/modal/animations/md.leave.ts | 2 +- .../core/src/components/modal/modal.ios.scss | 4 - .../src/components/modal/modal.ios.vars.scss | 3 - .../core/src/components/modal/modal.md.scss | 3 - .../src/components/modal/modal.md.vars.scss | 3 - packages/core/src/components/modal/modal.scss | 26 +------ packages/core/src/components/modal/modal.tsx | 57 +++++++------- packages/core/src/components/nav/nav.tsx | 3 +- .../components/picker/animations/ios.enter.ts | 2 +- .../components/picker/animations/ios.leave.ts | 2 +- .../core/src/components/picker/picker.tsx | 29 +++----- .../popover/animations/ios.enter.ts | 2 +- .../popover/animations/ios.leave.ts | 2 +- .../components/popover/animations/md.enter.ts | 2 +- .../components/popover/animations/md.leave.ts | 2 +- .../src/components/popover/popover.ios.scss | 4 - .../src/components/popover/popover.md.scss | 4 - .../components/popover/popover.md.vars.scss | 3 - .../core/src/components/popover/popover.scss | 23 ------ .../core/src/components/popover/popover.tsx | 74 +++++++++---------- 51 files changed, 221 insertions(+), 271 deletions(-) diff --git a/packages/core/src/components.d.ts b/packages/core/src/components.d.ts index f333349148..e3c525107e 100644 --- a/packages/core/src/components.d.ts +++ b/packages/core/src/components.d.ts @@ -342,7 +342,9 @@ declare global { } namespace JSXElements { export interface IonBackdropAttributes extends HTMLAttributes { - mode?: 'ios' | 'md'; + stopPropagation?: boolean; + tappable?: boolean; + visible?: boolean; } } } diff --git a/packages/core/src/components/action-sheet/action-sheet.scss b/packages/core/src/components/action-sheet/action-sheet.scss index b72eaf8526..75c8f47eaa 100644 --- a/packages/core/src/components/action-sheet/action-sheet.scss +++ b/packages/core/src/components/action-sheet/action-sheet.scss @@ -13,6 +13,8 @@ ion-action-sheet { width: $action-sheet-width; height: $action-sheet-width; + touch-action: none; + font-smoothing: antialiased; -webkit-font-smoothing: antialiased; } diff --git a/packages/core/src/components/action-sheet/action-sheet.tsx b/packages/core/src/components/action-sheet/action-sheet.tsx index 6fba5bb936..f821d08170 100644 --- a/packages/core/src/components/action-sheet/action-sheet.tsx +++ b/packages/core/src/components/action-sheet/action-sheet.tsx @@ -195,10 +195,9 @@ export class ActionSheet { this.dismiss(); } - protected backdropClick() { - if (this.enableBackdropDismiss) { - this.dismiss(); - } + @Listen('ionBackdropTap') + protected onBackdropTap() { + this.dismiss(); } protected buttonClick(button: ActionSheetButton) { @@ -238,9 +237,7 @@ export class ActionSheet { const buttons = allButtons.filter(b => b.role !== 'cancel'); return [ - , + ,