javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-24 14:58:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(react): Don't render overlay children if isOpen is false, fixes #20225 (#20226)

Browse Source
This commit is contained in:
Ely Lucas
2020-01-17 15:42:58 -07:00
committed by GitHub
parent 22f92294ce
commit aff9612d11
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/react/src/components/createOverlayComponent.tsx
View File

@ -40,7 +40,7 @@ export const createOverlayComponent = <OverlayComponent extends object, OverlayT
} }
componentDidMount() { componentDidMount() {
if (this.props.isOpen as boolean) { if (this.props.isOpen) {
this.present(); this.present();
} }
} }
@ -92,7 +92,7 @@ export const createOverlayComponent = <OverlayComponent extends object, OverlayT
render() { render() {
return ReactDOM.createPortal( return ReactDOM.createPortal(
this.props.children, this.props.isOpen ? this.props.children : null,
this.el this.el
); );
} }