javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-17 18:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

docs(test): add locale best practice (#28699)

Browse Source 
This best practice currently resides in our internal testing process
docs. I think this is valuable information for contributors to have as
well, so I've added it to our public best practices doc.
This commit is contained in:
Liam DeBeasi
2023-12-13 13:33:52 -05:00
committed by GitHub
parent ec07e70d99
commit ae6c353b51
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/src/utils/test/playwright/docs/best-practices.md
View File

@ -18,6 +18,7 @@ This guide details best practices that should be followed when writing E2E tests
- [Test for positive and negative cases](#practice-positive-negative) - [Test for positive and negative cases](#practice-positive-negative)
- [Start your test with the configuration or layout in place if possible](#practice-test-config) - [Start your test with the configuration or layout in place if possible](#practice-test-config)
- [Place your test closest to the fix or feature](#practice-test-close) - [Place your test closest to the fix or feature](#practice-test-close)
- [Account for different locales when writing tests](#practice-locales)
<h2 id="practice-test">Use the customized `test` function</h2> <h2 id="practice-test">Use the customized `test` function</h2>
@ -259,3 +260,7 @@ This allows tests to remain fast on CI as we can focus on the test itself instea
<h2 id="practice-test-close">Place your test closest to the fix or feature</h2> <h2 id="practice-test-close">Place your test closest to the fix or feature</h2>
Tests should be placed closest to where the fix or feature was implemented. This means that if a fix was written for `ion-button`, then the test should be placed in `src/components/button/tests`. Tests should be placed closest to where the fix or feature was implemented. This means that if a fix was written for `ion-button`, then the test should be placed in `src/components/button/tests`.
<h2 id="practice-locales">Account for different locales when writing tests</h2>
Tests ran on CI may not run on the same locale as your local machine. It's always a good idea to apply locale considerations to components that support it, when writing tests (i.e. `ion-datetime` should specify `locale="en-US"`).