From add33c5995075325b9e92854eb7fc49eb220c02d Mon Sep 17 00:00:00 2001 From: Brandy Smith Date: Wed, 15 Oct 2025 13:50:12 -0400 Subject: [PATCH] refactor(button): only check for undefined fill (#30722) Issue number: internal --------- ## What is the current behavior? Button checks for undefined and null fill as a result of Stencil bug https://github.com/ionic-team/stencil/issues/3586 ## What is the new behavior? - Removes check for `null` with the release of Stencil v4.38.0 - No test needed as one exists already: https://github.com/ionic-team/ionic-framework/pull/26339/files ## Does this introduce a breaking change? - [ ] Yes - [x] No Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com> --- core/src/components/button/button.tsx | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/core/src/components/button/button.tsx b/core/src/components/button/button.tsx index 47326abfea..9eecd0d2c6 100644 --- a/core/src/components/button/button.tsx +++ b/core/src/components/button/button.tsx @@ -361,11 +361,7 @@ export class Button implements ComponentInterface, AnchorInterface, ButtonInterf target, }; let fill = this.fill; - /** - * We check both undefined and null to - * work around https://github.com/ionic-team/stencil/issues/3586. - */ - if (fill == null) { + if (fill === undefined) { fill = this.inToolbar || this.inListHeader ? 'clear' : 'solid'; }