From ac66215399954c972267b9d18bbd5aa5ef41a4c1 Mon Sep 17 00:00:00 2001
From: Sean Perkins <sean@ionic.io>
Date: Tue, 28 Feb 2023 17:42:08 -0500
Subject: [PATCH] fix(datetime): aria-label for show/hide year picker (#26848)

---
 core/src/components/datetime/datetime.tsx     | 32 ++++++++++--
 .../datetime/test/a11y/datetime.spec.ts       | 52 +++++++++++++++++++
 2 files changed, 81 insertions(+), 3 deletions(-)
 create mode 100644 core/src/components/datetime/test/a11y/datetime.spec.ts

diff --git a/core/src/components/datetime/datetime.tsx b/core/src/components/datetime/datetime.tsx
index 0a00353220..12a8556a63 100644
--- a/core/src/components/datetime/datetime.tsx
+++ b/core/src/components/datetime/datetime.tsx
@@ -82,6 +82,7 @@ import {
 export class Datetime implements ComponentInterface {
   private inputId = `ion-dt-${datetimeIds++}`;
   private calendarBodyRef?: HTMLElement;
+  private monthYearToggleItemRef?: HTMLIonItemElement;
   private popoverRef?: HTMLIonPopoverElement;
   private clearFocusVisible?: () => void;
   private parsedMinuteValues?: number[];
@@ -1890,7 +1891,32 @@ export class Datetime implements ComponentInterface {
       <div class="calendar-header">
         <div class="calendar-action-buttons">
           <div class="calendar-month-year">
-            <ion-item button detail={false} lines="none" onClick={() => this.toggleMonthAndYearView()}>
+            <ion-item
+              ref={(el) => (this.monthYearToggleItemRef = el)}
+              button
+              aria-label="Show year picker"
+              detail={false}
+              lines="none"
+              onClick={() => {
+                this.toggleMonthAndYearView();
+                /**
+                 * TODO: FW-3547
+                 *
+                 * Currently there is not a way to set the aria-label on the inner button
+                 * on the `ion-item` and have it be reactive to changes. This is a workaround
+                 * until we either refactor `ion-item` to a button or Stencil adds a way to
+                 * have reactive props for built-in properties, such as `aria-label`.
+                 */
+                const { monthYearToggleItemRef } = this;
+                if (monthYearToggleItemRef) {
+                  const btn = monthYearToggleItemRef.shadowRoot?.querySelector('.item-native');
+                  if (btn) {
+                    const monthYearAriaLabel = this.showMonthAndYear ? 'Hide year picker' : 'Show year picker';
+                    btn.setAttribute('aria-label', monthYearAriaLabel);
+                  }
+                }
+              }}
+            >
               <ion-label>
                 {getMonthAndYear(this.locale, this.workingParts)}
                 <ion-icon
@@ -1905,7 +1931,7 @@ export class Datetime implements ComponentInterface {
 
           <div class="calendar-next-prev">
             <ion-buttons>
-              <ion-button aria-label="previous month" disabled={prevMonthDisabled} onClick={() => this.prevMonth()}>
+              <ion-button aria-label="Previous month" disabled={prevMonthDisabled} onClick={() => this.prevMonth()}>
                 <ion-icon
                   dir={hostDir}
                   aria-hidden="true"
@@ -1915,7 +1941,7 @@ export class Datetime implements ComponentInterface {
                   flipRtl
                 ></ion-icon>
               </ion-button>
-              <ion-button aria-label="next month" disabled={nextMonthDisabled} onClick={() => this.nextMonth()}>
+              <ion-button aria-label="Next month" disabled={nextMonthDisabled} onClick={() => this.nextMonth()}>
                 <ion-icon
                   dir={hostDir}
                   aria-hidden="true"
diff --git a/core/src/components/datetime/test/a11y/datetime.spec.ts b/core/src/components/datetime/test/a11y/datetime.spec.ts
new file mode 100644
index 0000000000..619efd425c
--- /dev/null
+++ b/core/src/components/datetime/test/a11y/datetime.spec.ts
@@ -0,0 +1,52 @@
+import type { SpecPage } from '@stencil/core/testing';
+import { newSpecPage } from '@stencil/core/testing';
+
+import { Item } from '../../../item/item';
+import { Datetime } from '../../datetime';
+
+describe('datetime', () => {
+  beforeEach(() => {
+    const mockIntersectionObserver = jest.fn();
+    mockIntersectionObserver.mockReturnValue({
+      observe: () => null,
+      unobserve: () => null,
+      disconnect: () => null,
+    });
+    global.IntersectionObserver = mockIntersectionObserver;
+  });
+
+  describe('month/year toggle', () => {
+    let page: SpecPage;
+
+    beforeEach(async () => {
+      page = await newSpecPage({
+        components: [Datetime, Item],
+        html: `<ion-datetime></ion-datetime>`,
+      });
+    });
+
+    it('should have aria-label "Show year picker" when collapsed', async () => {
+      const datetime = page.body.querySelector('ion-datetime')!;
+      const item = datetime.shadowRoot!.querySelector('.calendar-month-year ion-item');
+      const monthYearToggleBtn = item!.shadowRoot!.querySelector('button');
+      const ariaLabel = monthYearToggleBtn!.getAttribute('aria-label');
+
+      expect(ariaLabel).toContain('Show year picker');
+    });
+
+    it('should have aria-label "Hide year picker" when expanded', async () => {
+      const datetime = page.body.querySelector('ion-datetime')!;
+      const item = datetime.shadowRoot!.querySelector<HTMLIonItemElement>('.calendar-month-year ion-item');
+
+      item!.click();
+
+      await page.waitForChanges();
+
+      const itemAfter = datetime.shadowRoot!.querySelector<HTMLIonItemElement>('.calendar-month-year ion-item');
+      const monthYearToggleBtn = itemAfter!.shadowRoot!.querySelector<HTMLElement>('button');
+      const ariaLabel = monthYearToggleBtn!.getAttribute('aria-label');
+
+      expect(ariaLabel).toContain('Hide year picker');
+    });
+  });
+});