javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-08 23:58:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(router-outlet): navigating to same route with different params now activates component (#24760)

Browse Source 
resolves #24653
This commit is contained in:
Victor Berchet
2022-02-11 07:08:53 -08:00
committed by GitHub
parent 7b3838cc67
commit abc36ae80b
6 changed files with 75 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
core/src/components/nav/view-controller.ts
View File

@ -1,6 +1,6 @@
import { AnimationBuilder, ComponentProps, FrameworkDelegate, NavComponentWithProps } from '../../interface';
import { attachComponent } from '../../utils/framework-delegate';
import { assert } from '../../utils/helpers';
import { assert, shallowEqualStringMap } from '../../utils/helpers';
export const VIEW_STATE_NEW = 1;
export const VIEW_STATE_ATTACHED = 2;
@ -54,29 +54,8 @@ export const matches = (view: ViewController | undefined, id: string, params: Co
if (view.component !== id) {
return false;
}
const currentParams = view.params;
if (currentParams === params) {
return true;
}
if (!currentParams && !params) {
return true;
}
if (!currentParams || !params) {
return false;
}
const keysA = Object.keys(currentParams);
const keysB = Object.keys(params);
if (keysA.length !== keysB.length) {
return false;
}
// Test for A's keys different from B.
for (const key of keysA) {
if (currentParams[key] !== params[key]) {
return false;
}
}
return true;
return shallowEqualStringMap(view.params, params);
};
export const convertToView = (page: any, params: ComponentProps | undefined): ViewController | null => {