javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-18 03:00:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(menu): refs are not destroyed on unmount (#27158)

Browse Source
This commit is contained in:
Liam DeBeasi
2023-04-10 15:38:46 -04:00
committed by GitHub
parent a5f7fe546a
commit ab6cdff97e
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
core/src/components/menu/menu.tsx
View File

@ -234,7 +234,16 @@ export class Menu implements ComponentInterface, MenuI {
this.updateState(); this.updateState();
} }
disconnectedCallback() { async disconnectedCallback() {
/**
* The menu should be closed when it is
* unmounted from the DOM.
* This is an async call, so we need to wait for
* this to finish otherwise contentEl
* will not have MENU_CONTENT_OPEN removed.
*/
await this.close(false);
this.blocker.destroy(); this.blocker.destroy();
menuController._unregister(this); menuController._unregister(this);
if (this.animation) { if (this.animation) {
@ -246,7 +255,7 @@ export class Menu implements ComponentInterface, MenuI {
} }
this.animation = undefined; this.animation = undefined;
this.contentEl = this.backdropEl = this.menuInnerEl = undefined; this.contentEl = undefined;
} }
@Listen('ionSplitPaneVisible', { target: 'body' }) @Listen('ionSplitPaneVisible', { target: 'body' })