javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(datetime): persist minutes column on hour change (#24829)

Browse Source 
Resolves #24821
This commit is contained in:
Sean Perkins
2022-02-28 13:51:52 -05:00
committed by GitHub
parent e4ec572043
commit aacb58a322
3 changed files with 156 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
core/src/components/picker-column-internal/picker-column-internal.tsx
View File

@ -118,6 +118,25 @@ export class PickerColumnInternal implements ComponentInterface {
}
}
componentDidRender() {
const { activeItem, items, isColumnVisible, value } = this;
if (isColumnVisible) {
if (activeItem) {
this.scrollActiveItemIntoView();
} else if (items[0]?.value !== value) {
/**
* If the picker column does not have an active item and the current value
* does not match the first item in the picker column, that means
* the value is out of bounds. In this case, we assign the value to the
* first item to match the scroll position of the column.
*
*/
this.value = items[0].value;
}
}
}
/** @internal */
@Method()
async scrollActiveItemIntoView() {
@ -129,12 +148,19 @@ export class PickerColumnInternal implements ComponentInterface {
}
private centerPickerItemInView = (target: HTMLElement, smooth = true) => {
this.el.scroll({
const { el, isColumnVisible } = this;
if (isColumnVisible) {
// (Vertical offset from parent) - (three empty picker rows) + (half the height of the target to ensure the scroll triggers)
top: target.offsetTop - (3 * target.clientHeight) + (target.clientHeight / 2),
left: 0,
behavior: smooth ? 'smooth' : undefined
});
const top = target.offsetTop - (3 * target.clientHeight) + (target.clientHeight / 2);
if (el.scrollTop !== top) {
el.scroll({
top,
left: 0,
behavior: smooth ? 'smooth' : undefined
});
}
}
}
/**