From aa9d0d42827446cb2702d88775ecbb4c286523bd Mon Sep 17 00:00:00 2001
From: "Manu Mtz.-Almeida" <manu.mtza@gmail.com>
Date: Mon, 3 Dec 2018 19:48:12 +0100
Subject: [PATCH] fix(all): type issues with TS 3.2

---
 core/src/components/anchor/anchor.tsx               | 2 +-
 core/src/components/back-button/back-button.tsx     | 2 +-
 core/src/components/datetime/datetime.tsx           | 8 ++++----
 core/src/components/fab-button/fab-button.tsx       | 2 +-
 core/src/components/picker-column/picker-column.tsx | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/core/src/components/anchor/anchor.tsx b/core/src/components/anchor/anchor.tsx
index 92c9992f50..c405d2ef0f 100644
--- a/core/src/components/anchor/anchor.tsx
+++ b/core/src/components/anchor/anchor.tsx
@@ -42,7 +42,7 @@ export class Anchor implements ComponentInterface {
     return (
       <a
         href={this.href}
-        onClick={ev => openURL(this.win, this.href, ev, this.routerDirection)}
+        onClick={(ev: Event) => openURL(this.win, this.href, ev, this.routerDirection)}
       >
         <slot></slot>
       </a>
diff --git a/core/src/components/back-button/back-button.tsx b/core/src/components/back-button/back-button.tsx
index 1705b1897c..abf782c67b 100644
--- a/core/src/components/back-button/back-button.tsx
+++ b/core/src/components/back-button/back-button.tsx
@@ -79,7 +79,7 @@ export class BackButton implements ComponentInterface {
       <button
         type="button"
         class="button-native"
-        onClick={ev => this.onClick(ev)}
+        onClick={(ev: Event) => this.onClick(ev)}
       >
         <span class="button-inner">
           {backButtonIcon && <ion-icon icon={backButtonIcon} lazy={false}></ion-icon>}
diff --git a/core/src/components/datetime/datetime.tsx b/core/src/components/datetime/datetime.tsx
index 3c77f1014c..7134e1f00a 100644
--- a/core/src/components/datetime/datetime.tsx
+++ b/core/src/components/datetime/datetime.tsx
@@ -421,16 +421,16 @@ export class Datetime implements ComponentInterface {
     );
   }
 
-  private calcMinMax(now?: Date) {
-    const todaysYear = (now || new Date()).getFullYear();
+  private calcMinMax() {
+    const todaysYear = new Date().getFullYear();
 
     if (this.yearValues !== undefined) {
       const years = convertToArrayOfNumbers(this.yearValues, 'year');
       if (this.min === undefined) {
-        this.min = Math.min.apply(Math, years);
+        this.min = Math.min(...years).toString();
       }
       if (this.max === undefined) {
-        this.max = Math.max.apply(Math, years);
+        this.max = Math.max(...years).toString();
       }
     } else {
       if (this.min === undefined) {
diff --git a/core/src/components/fab-button/fab-button.tsx b/core/src/components/fab-button/fab-button.tsx
index c954be83fe..4743907d3e 100755
--- a/core/src/components/fab-button/fab-button.tsx
+++ b/core/src/components/fab-button/fab-button.tsx
@@ -122,7 +122,7 @@ export class FabButton implements ComponentInterface {
         onFocus={this.onFocus}
         onKeyUp={this.onKeyUp}
         onBlur={this.onBlur}
-        onClick={ev => openURL(this.win, this.href, ev, this.routerDirection)}
+        onClick={(ev: Event) => openURL(this.win, this.href, ev, this.routerDirection)}
       >
         <span class="close-icon">
           <ion-icon name="close" lazy={false}></ion-icon>
diff --git a/core/src/components/picker-column/picker-column.tsx b/core/src/components/picker-column/picker-column.tsx
index d4b090cacc..a6ceec370f 100644
--- a/core/src/components/picker-column/picker-column.tsx
+++ b/core/src/components/picker-column/picker-column.tsx
@@ -99,7 +99,7 @@ export class PickerColumnCmp implements ComponentInterface {
     let translateZ = 0;
     const { col, rotateFactor } = this;
     const selectedIndex = col.selectedIndex = this.indexForY(-y);
-    const durationStr = (duration === 0) ? null : duration + 'ms';
+    const durationStr = (duration === 0) ? '' : duration + 'ms';
     const scaleStr = `scale(${this.scaleFactor})`;
 
     const children = this.optsEl.children;