fix(chip): descenders are not clipped in label (#26729)

resolves #18313
This commit is contained in:
Liam DeBeasi
2023-02-03 15:00:22 -05:00
committed by GitHub
parent d084557bbc
commit a9e000b433
5 changed files with 24 additions and 2 deletions

View File

@ -27,8 +27,6 @@
font-family: $font-family-base;
font-size: 14px;
line-height: 1;
cursor: pointer;
overflow: hidden;

View File

@ -9,4 +9,28 @@ test.describe('chip: rendering', () => {
expect(await page.screenshot()).toMatchSnapshot(`chip-basic-${page.getSnapshotSettings()}.png`);
});
test('should not clip descenders in item', async ({ page, skip }) => {
skip.rtl();
skip.mode('md');
test.info().annotations.push({
type: 'issue',
description: 'https://github.com/ionic-team/ionic-framework/issues/18313',
});
await page.setContent(`
<ion-list>
<ion-item>
<ion-chip>
<ion-label>Agreements</ion-label>
</ion-chip>
</ion-item>
</ion-list>
`);
const chip = page.locator('ion-chip');
expect(await chip.screenshot()).toMatchSnapshot(`chip-descender-${page.getSnapshotSettings()}.png`);
});
});

Binary file not shown.

After

Width:  |  Height:  |  Size: 5.7 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 1.8 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 5.8 KiB