octicon-mirror(24/)
javascript/ionic-framework
octicon-rss(16/)
1
0
octicon-repo-forked(16/)Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 22:44:13 +08:00
octicon-code(16/) Code octicon-issue-opened(16/) Issues octicon-package(16/) Packages octicon-project(16/) Projects octicon-tag(16/) Releases octicon-book(16/) Wiki octicon-pulse(16/) Activity

fix(popover): update placement per md spec (#17429)

Browse Source
This commit is contained in:
octicon-git-branch(16/)
octicon-tag(16/)
Asif Rahman
2019-02-27 16:45:06 -05:00
committed by Liam DeBeasi
gitea-unlock(16/)
parent 484d92cd50
commit a99d17952b
octicon-diff(16/tw-mr-1) 1 changed files with 4 additions and 3 deletions
gitea-whitespace(16/)
gitea-split(16/)
octicon-kebab-horizontal(16/)
Download Patch File Download Diff File Expand all files Collapse all files

7
core/src/components/popover/animations/md.enter.ts
View File

@@ -22,9 +22,10 @@ export function mdEnterAnimation(AnimationC: Animation, baseEl: HTMLElement, ev?
const targetDim =
ev && ev.target && (ev.target as HTMLElement).getBoundingClientRect();
// As per MD spec, by default position the popover below the target (trigger) element
const targetTop =
targetDim != null && 'top' in targetDim
? targetDim.top
targetDim != null && 'bottom' in targetDim
? targetDim.bottom
: bodyHeight / 2 - contentHeight / 2;
const targetLeft =
@@ -60,7 +61,7 @@ export function mdEnterAnimation(AnimationC: Animation, baseEl: HTMLElement, ev?
targetTop + targetHeight + contentHeight > bodyHeight &&
targetTop - contentHeight > 0
) {
popoverCSS.top = targetTop - contentHeight;
popoverCSS.top = targetTop - contentHeight - targetHeight;
baseEl.className = baseEl.className + ' popover-bottom';
originY = 'bottom';
// If there isn't room for it to pop up above the target cut it off