javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-23 14:01:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): use custom typing, remove interfaces

Browse Source 
add protected, rename nav `remove` to `removeIndex`

resolves #12823
This commit is contained in:
Brandy Carney
2017-10-17 13:17:54 -04:00
parent 7fc0310896
commit a932e673ff
53 changed files with 661 additions and 6948 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/core/src/components/segment/segment.tsx
View File

@ -1,4 +1,4 @@
import { Component, Element, Event, EventEmitter, HostElement, Listen, Prop, PropDidChange } from '@stencil/core';
import { Component, Element, Event, EventEmitter, Listen, Prop, PropDidChange } from '@stencil/core';
import { SegmentButtonEvent } from '../../index';
@ -71,7 +71,9 @@ import { SegmentButtonEvent } from '../../index';
}
})
export class Segment {
buttons: NodeListOf<HostElement>;
// TODO typing
buttons: any;
@Element() el: HTMLElement;
@Event() ionChange: EventEmitter;
@ -85,11 +87,11 @@ export class Segment {
this.selectButton(val);
}
ionViewDidLoad() {
this.buttons = this.el.querySelectorAll('ion-segment-button') as NodeListOf<HostElement>;
protected ionViewDidLoad() {
this.buttons = this.el.querySelectorAll('ion-segment-button');
for (var i = 0; i < this.buttons.length; i++) {
const button = this.buttons[i].$instance;
const button = this.buttons[i];
button.activated = (button.value === this.value);
@ -116,7 +118,7 @@ export class Segment {
selectButton(val: string) {
for (var i = 0; i < this.buttons.length; i++) {
const button = this.buttons[i].$instance;
const button = this.buttons[i];
button.activated = (button.value === val);
}