javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 16:16:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): use custom typing, remove interfaces

Browse Source 
add protected, rename nav `remove` to `removeIndex`

resolves #12823
This commit is contained in:
Brandy Carney
2017-10-17 13:17:54 -04:00
parent 7fc0310896
commit a932e673ff
53 changed files with 661 additions and 6948 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/core/src/components/action-sheet/action-sheet.tsx
View File

@ -38,7 +38,7 @@ export class ActionSheet {
@Prop() enterAnimation: AnimationBuilder;
@Prop() exitAnimation: AnimationBuilder;
@Prop() id: string;
@Prop() actionSheetId: string;
present() {
@ -138,7 +138,7 @@ export class ActionSheet {
}
}
protected click(button: ActionSheetButton) {
protected buttonClick(button: ActionSheetButton) {
let shouldDismiss = true;
if (button.handler) {
if (button.handler() === false) {
@ -188,7 +188,7 @@ export class ActionSheet {
? <div class='action-sheet-sub-title'>{this.subTitle}</div>
: null}
{buttons.map(b =>
<button class={this.buttonClass(b)} onClick={() => this.click(b)}>
<button class={this.buttonClass(b)} onClick={() => this.buttonClick(b)}>
<span class='button-inner'>
{b.icon
? <ion-icon name={b.icon} class='action-sheet-icon' />
@ -202,7 +202,7 @@ export class ActionSheet {
? <div class='action-sheet-group action-sheet-group-cancel'>
<button
class={this.buttonClass(cancelButton)}
onClick={() => this.click(cancelButton)}
onClick={() => this.buttonClick(cancelButton)}
>
{cancelButton.icon
? <ion-icon