diff --git a/core/package.json b/core/package.json index 22d947e5ba..b7e1c55b5c 100644 --- a/core/package.json +++ b/core/package.json @@ -39,7 +39,7 @@ "@types/jest": "^23.3.13", "@types/node": "10.12.18", "@types/puppeteer": "1.11.2", - "@types/swiper": "4.4.1", + "@types/swiper": "^4.4.2", "agadoo": "^1.0.0", "autoprefixer": "9.4.6", "aws-sdk": "^2.320.0", diff --git a/core/src/components/slides/slides.tsx b/core/src/components/slides/slides.tsx index 0255cfa85f..63c91dfbf1 100644 --- a/core/src/components/slides/slides.tsx +++ b/core/src/components/slides/slides.tsx @@ -364,6 +364,7 @@ export class Slides implements ComponentInterface { touchRatio: 1, touchAngle: 45, simulateTouch: true, + touchStartPreventDefault: false, shortSwipes: true, longSwipes: true, longSwipesRatio: 0.5, diff --git a/core/src/components/slides/test/prevent-default/e2e.ts b/core/src/components/slides/test/prevent-default/e2e.ts new file mode 100644 index 0000000000..f25692e74e --- /dev/null +++ b/core/src/components/slides/test/prevent-default/e2e.ts @@ -0,0 +1,33 @@ +import { newE2EPage } from '@stencil/core/testing'; + +test('slides: prevent-default', async () => { + // For this specific test, _testing=false to import tap-click in app.tsx + const page = await newE2EPage({ + url: '/src/components/slides/test/prevent-default?ionic:_testing=false' + }); + + const screenshotCompares = []; + + screenshotCompares.push(await page.compareScreenshot()); + + const scroller = await page.find('#scrollDownButton'); + const button = await page.find('#changeBackgroundButton'); + const contentWithBackground = await page.find('#contentWithBackground'); + + await page.waitFor(500); + + await scroller.click(); + await page.waitFor(500); + + screenshotCompares.push(await page.compareScreenshot('scroll down button')); + + await button.click(); + + screenshotCompares.push(await page.compareScreenshot('change background')); + + expect(contentWithBackground).toHaveClasses(['blueBackground']); + + for (const screenshotCompare of screenshotCompares) { + expect(screenshotCompare).toMatchScreenshot(); + } +}); diff --git a/core/src/components/slides/test/prevent-default/index.html b/core/src/components/slides/test/prevent-default/index.html new file mode 100644 index 0000000000..f5cdd34009 --- /dev/null +++ b/core/src/components/slides/test/prevent-default/index.html @@ -0,0 +1,51 @@ + + + + + + Slides - Prevent Default + + + + + + + + + + + + + + +
+ Scroll down +
+
+ Change Background +
+ + + + + + + + + + \ No newline at end of file