javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-23 05:58:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(virtual-scroll): use correct item top calculation with header or footer function (#15948) (#17345)

Browse Source 
- use the right index in updateVDom to update the top transition ()
- extend unit test to verify the top is also calculated right with a given headerFn and footerFn
- update the visibility of the node also if a given approxHeaderHeight/approxFooterHeight matches the calculated height

fixes #15948 fixes #17298
This commit is contained in:
David Boho
2019-03-26 21:17:03 +01:00
committed by Brandy Carney
parent 016fa16d44
commit a8a48a4ca4
3 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/components/virtual-scroll/virtual-scroll-utils.ts
View File

@ -46,7 +46,7 @@ export function updateVDom(dom: VirtualNode[], heightIndex: Uint32Array, cells:
for (const cell of toMutate) {
const node = pool.find(n => n.d && n.cell.type === cell.type);
const index = cell.index;
const index = cell.i;
if (node) {
node.d = false;
node.change = NODE_CHANGE_CELL;