From a869ca0bba48e664af12e6645ae5434a60890693 Mon Sep 17 00:00:00 2001
From: Amy Marsh <19311766+amymarsh4work@users.noreply.github.com>
Date: Wed, 24 Jul 2019 17:35:50 -0400
Subject: [PATCH] (fix): define top-level ARIA landmark regions to improve
accessibility (#18672)
references #18671
---
core/src/components/content/content.tsx | 6 ++++--
core/src/components/footer/footer.tsx | 1 +
core/src/components/header/header.tsx | 1 +
3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/core/src/components/content/content.tsx b/core/src/components/content/content.tsx
index 4cd5254c26..8e5734fb5e 100644
--- a/core/src/components/content/content.tsx
+++ b/core/src/components/content/content.tsx
@@ -319,7 +319,7 @@ export class Content implements ComponentInterface {
'--offset-bottom': `${this.cBottom}px`,
}}
>
-
this.onScroll(ev)}
>
-
+
+
{transitionShadow ? (
) : null}
+
);
diff --git a/core/src/components/footer/footer.tsx b/core/src/components/footer/footer.tsx
index a17cafb7a0..9fc60c5dd6 100644
--- a/core/src/components/footer/footer.tsx
+++ b/core/src/components/footer/footer.tsx
@@ -27,6 +27,7 @@ export class Footer implements ComponentInterface {
hostData() {
const mode = getIonMode(this);
return {
+ role: 'contentinfo',
class: {
[mode]: true,
diff --git a/core/src/components/header/header.tsx b/core/src/components/header/header.tsx
index 159fc7c7d6..0a77566942 100644
--- a/core/src/components/header/header.tsx
+++ b/core/src/components/header/header.tsx
@@ -27,6 +27,7 @@ export class Header implements ComponentInterface {
hostData() {
const mode = getIonMode(this);
return {
+ role: 'banner',
class: {
[mode]: true,