javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(router): change detection for componentProps

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-03-27 00:57:50 +02:00
parent ffaec1661a
commit a718f7e1e3
4 changed files with 45 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
core/src/components/route/route.tsx
View File

@ -1,4 +1,4 @@
import { Component, Event, Prop } from '@stencil/core';
import { Component, Event, Prop, Watch } from '@stencil/core';
import { EventEmitter } from 'ionicons/dist/types/stencil.core';
@Component({
@ -28,7 +28,33 @@ export class Route {
/**
* Used internaly by `ion-router` to know when this route did change.
*/
@Event() ionRouteDataChanged: EventEmitter;
@Event() ionRouteDataChanged: EventEmitter<any>;
@Watch('url')
@Watch('component')
onUpdate(newValue: any) {
this.ionRouteDataChanged.emit(newValue);
}
@Watch('componentProps')
onComponentProps(newValue: any, oldValue: any) {
if (newValue === oldValue) {
return;
}
const keys1 = newValue ? Object.keys(newValue) : [];
const keys2 = oldValue ? Object.keys(oldValue) : [];
if (keys1.length !== keys2.length) {
this.onUpdate(newValue);
return;
}
for (let i = 0; i < keys1.length; i++) {
const key = keys1[i];
if (newValue[key] !== oldValue[key]) {
this.onUpdate(newValue);
return;
}
}
}
componentDidLoad() {
this.ionRouteDataChanged.emit();
@ -36,7 +62,4 @@ export class Route {
componentDidUnload() {
this.ionRouteDataChanged.emit();
}
componentDidUpdate() {
this.ionRouteDataChanged.emit();
}
}