javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat(toast): add global config toastDuration (#26425)

Browse Source 
Co-authored-by: DwieDima <DwieDima@users.noreply.github.com>
This commit is contained in:
Amanda Johnston
2022-12-06 09:52:52 -06:00
committed by GitHub
parent 1b30fc97d3
commit a67a827fed
4 changed files with 38 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
core/src/components/toast/test/basic/toast.e2e.ts
View File

@ -1,5 +1,5 @@
import { expect } from '@playwright/test';
import type { Locator, TestInfo } from '@playwright/test';
import { expect } from '@playwright/test';
import type { E2EPage, EventSpy } from '@utils/test/playwright';
import { test } from '@utils/test/playwright';
@ -134,3 +134,31 @@ test.describe('toast: properties', () => {
await expect(toast).toHaveClass(/my-custom-class/);
});
});
test.describe('toast: duration config', () => {
test.beforeEach(({ skip }) => {
skip.rtl();
skip.mode('ios');
});
test('should have duration set to 0', async ({ page }) => {
await page.setContent(`
<ion-toast></ion-toast>
`);
const toast = page.locator('ion-toast');
await expect(toast).toHaveJSProperty('duration', 0);
});
test('should have duration set to 5000', async ({ page }) => {
await page.setContent(`
<ion-toast></ion-toast>
<script>
window.Ionic = {
config: { toastDuration: 5000 }
}
</script>
`);
const toast = page.locator('ion-toast');
await expect(toast).toHaveJSProperty('duration', 5000);
});
});

5
core/src/components/toast/toast.tsx
View File

@ -1,6 +1,7 @@
import type { ComponentInterface, EventEmitter } from '@stencil/core';
import { Component, Element, Event, Host, Method, Prop, h } from '@stencil/core';
import { Component, Element, Event, h, Host, Method, Prop } from '@stencil/core';
import { config } from '../../global/config';
import { getIonMode } from '../../global/ionic-global';
import type {
AnimationBuilder,
@ -77,7 +78,7 @@ export class Toast implements ComponentInterface, OverlayInterface {
* How many milliseconds to wait before hiding the toast. By default, it will show
* until `dismiss()` is called.
*/
@Prop() duration = 0;
@Prop() duration = config.getNumber('toastDuration', 0);
/**
* Header to be shown in the toast.