javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 08:09:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(modal): avoid chrome memory leak bug (#26911)

Browse Source
This commit is contained in:
Liam DeBeasi
2023-03-06 12:38:29 -05:00
committed by GitHub
parent 48c45afdb6
commit a3f8e28172
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/components/modal/test/basic/modal.e2e.ts
View File

@ -75,6 +75,7 @@ test.describe('modal: rendering', () => {
await ionModalDidPresent.next(); await ionModalDidPresent.next();
const modal = await page.locator('ion-modal'); const modal = await page.locator('ion-modal');
await expect(modal).toHaveClass(/show-modal/);
await page.setIonViewport(); await page.setIonViewport();
@ -87,6 +88,7 @@ test.describe('modal: rendering', () => {
await ionModalWillDismiss.next(); await ionModalWillDismiss.next();
await ionModalDidDismiss.next(); await ionModalDidDismiss.next();
await expect(modal).not.toHaveClass(/show-modal/);
await expect(modal).toBeHidden(); await expect(modal).toBeHidden();
}; };

6
core/src/css/core.scss
View File

@ -91,8 +91,12 @@ html.ios ion-modal ion-toolbar {
* Note 2: This should only apply to non-card and * Note 2: This should only apply to non-card and
* non-sheet modals. Card and sheet modals have their * non-sheet modals. Card and sheet modals have their
* own criteria for displaying backdrops/box shadows. * own criteria for displaying backdrops/box shadows.
*
* Do not use :not(.overlay-hidden) in place of
* .show-modal because that triggers a memory
* leak in Blink: https://bugs.chromium.org/p/chromium/issues/detail?id=1418768
*/ */
ion-modal.modal-default:not(.overlay-hidden) ~ ion-modal.modal-default { ion-modal.modal-default.show-modal ~ ion-modal.modal-default {
--backdrop-opacity: 0; --backdrop-opacity: 0;
--box-shadow: none; --box-shadow: none;
} }