javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-19 19:57:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(picker-column): add cancelable check to avoid intervention error in chrome (#22140)

Browse Source 
resolves #22137
This commit is contained in:
Liam DeBeasi
2020-09-22 14:04:39 -04:00
committed by GitHub
parent 68afc49e9e
commit a24a041064
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/src/components/picker-column/picker-column.tsx
View File

@ -250,7 +250,9 @@ export class PickerColumnCmp implements ComponentInterface {
// We have to prevent default in order to block scrolling under the picker // We have to prevent default in order to block scrolling under the picker
// but we DO NOT have to stop propagation, since we still want // but we DO NOT have to stop propagation, since we still want
// some "click" events to capture // some "click" events to capture
detail.event.preventDefault(); if (detail.event.cancelable) {
detail.event.preventDefault();
}
detail.event.stopPropagation(); detail.event.stopPropagation();
hapticSelectionStart(); hapticSelectionStart();
@ -272,7 +274,9 @@ export class PickerColumnCmp implements ComponentInterface {
} }
private onMove(detail: GestureDetail) { private onMove(detail: GestureDetail) {
detail.event.preventDefault(); if (detail.event.cancelable) {
detail.event.preventDefault();
}
detail.event.stopPropagation(); detail.event.stopPropagation();
// update the scroll position relative to pointer start position // update the scroll position relative to pointer start position