javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 04:14:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(overlays): thrown errors are no longer suppressed (#23831)

Browse Source 
resolves #22724
This commit is contained in:
Liam DeBeasi
2021-08-27 12:51:17 -04:00
committed by GitHub
parent 1d2ee92ca0
commit a212eb5259
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/src/utils/overlays.ts
View File

@ -528,6 +528,13 @@ export const isCancel = (role: string | undefined): boolean => {
const defaultGate = (h: any) => h(); const defaultGate = (h: any) => h();
/**
* Calls a developer provided method while avoiding
* Angular Zones. Since the handler is provided by
* the developer, we should throw any errors
* received so that developer-provided bug
* tracking software can log it.
*/
export const safeCall = (handler: any, arg?: any) => { export const safeCall = (handler: any, arg?: any) => {
if (typeof handler === 'function') { if (typeof handler === 'function') {
const jmp = config.get('_zoneGate', defaultGate); const jmp = config.get('_zoneGate', defaultGate);
@ -535,7 +542,7 @@ export const safeCall = (handler: any, arg?: any) => {
try { try {
return handler(arg); return handler(arg);
} catch (e) { } catch (e) {
console.error(e); throw e;
} }
}); });
} }