diff --git a/core/src/components/item/item.ionic.scss b/core/src/components/item/item.ionic.scss index 89c7b3fd2a..1288517ac7 100644 --- a/core/src/components/item/item.ionic.scss +++ b/core/src/components/item/item.ionic.scss @@ -76,11 +76,6 @@ slot[name="end"]::slotted(*) { // Item: Focused // -------------------------------------------------- -:host(.ion-focused) .item-native { - // This prevents the focus ring from clipping. - overflow: visible; -} - :host(.ion-focused) .item-native::after { @include globals.border-radius(inherit); @include globals.position(0, 0, 0, 0); @@ -100,11 +95,13 @@ slot[name="end"]::slotted(*) { // Full lines - apply the border to the item // Inset lines - apply the border to the item inner :host(.item-lines-full) { - --border-width: #{globals.$ion-border-size-0} #{globals.$ion-border-size-0} #{globals.$ion-border-size-025} #{globals.$ion-border-size-0}; + --border-width: #{globals.$ion-border-size-0 globals.$ion-border-size-0 globals.$ion-border-size-025 + globals.$ion-border-size-0}; } :host(.item-lines-inset) { - --inner-border-width: #{globals.$ion-border-size-0} #{globals.$ion-border-size-0} #{globals.$ion-border-size-025} #{globals.$ion-border-size-0}; + --inner-border-width: #{globals.$ion-border-size-0 globals.$ion-border-size-0 globals.$ion-border-size-025 + globals.$ion-border-size-0}; } // Full lines - remove the border from the item inner (inset list items) diff --git a/core/src/components/radio/radio.common.scss b/core/src/components/radio/radio.common.scss index 7e9376bdc0..eb4050c1d4 100644 --- a/core/src/components/radio/radio.common.scss +++ b/core/src/components/radio/radio.common.scss @@ -156,6 +156,17 @@ input { display: block; } +// Radio Label +// ---------------------------------------------------------------- + +.label-text-wrapper { + text-overflow: ellipsis; + + white-space: nowrap; + + overflow: hidden; +} + // Radio Label Placement - Start // ---------------------------------------------------------------- diff --git a/core/src/components/radio/radio.native.scss b/core/src/components/radio/radio.native.scss index d3ce542ea9..e715e859f7 100644 --- a/core/src/components/radio/radio.native.scss +++ b/core/src/components/radio/radio.native.scss @@ -12,14 +12,6 @@ // Radio Label // ---------------------------------------------------------------- -.label-text-wrapper { - text-overflow: ellipsis; - - white-space: nowrap; - - overflow: hidden; -} - :host(.in-item) .label-text-wrapper { @include margin($radio-item-label-margin-top, null, $radio-item-label-margin-bottom, null); } diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-ltr-light-Mobile-Chrome-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-ltr-light-Mobile-Chrome-linux.png index e71aebdd3f..9ee3e30324 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-ltr-light-Mobile-Chrome-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-ltr-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-ltr-light-Mobile-Firefox-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-ltr-light-Mobile-Firefox-linux.png index 5eb578622f..ffbdc837fb 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-ltr-light-Mobile-Firefox-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-ltr-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-ltr-light-Mobile-Safari-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-ltr-light-Mobile-Safari-linux.png index c9519e2222..841b65d4b2 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-ltr-light-Mobile-Safari-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-ltr-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-rtl-light-Mobile-Chrome-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-rtl-light-Mobile-Chrome-linux.png index f11dd191a4..f97d0909e1 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-rtl-light-Mobile-Chrome-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-rtl-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-rtl-light-Mobile-Firefox-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-rtl-light-Mobile-Firefox-linux.png index 24b3a7a688..6669781bd0 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-rtl-light-Mobile-Firefox-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-rtl-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-rtl-light-Mobile-Safari-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-rtl-light-Mobile-Safari-linux.png index 29c3986a34..61464c25b9 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-rtl-light-Mobile-Safari-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-end-ionic-md-rtl-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-ltr-light-Mobile-Chrome-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-ltr-light-Mobile-Chrome-linux.png index 4f9e9db237..e017b54017 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-ltr-light-Mobile-Chrome-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-ltr-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-ltr-light-Mobile-Firefox-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-ltr-light-Mobile-Firefox-linux.png index ce057e41ea..18eee9a255 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-ltr-light-Mobile-Firefox-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-ltr-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-ltr-light-Mobile-Safari-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-ltr-light-Mobile-Safari-linux.png index 49ff459e18..1a505acb42 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-ltr-light-Mobile-Safari-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-ltr-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-rtl-light-Mobile-Chrome-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-rtl-light-Mobile-Chrome-linux.png index 2af6fd8fca..7b3fe88a03 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-rtl-light-Mobile-Chrome-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-rtl-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-rtl-light-Mobile-Firefox-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-rtl-light-Mobile-Firefox-linux.png index a4bb758fb7..8ea69fa9d9 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-rtl-light-Mobile-Firefox-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-rtl-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-rtl-light-Mobile-Safari-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-rtl-light-Mobile-Safari-linux.png index e2a4ca8046..e1a3eb2612 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-rtl-light-Mobile-Safari-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-space-between-ionic-md-rtl-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-ltr-light-Mobile-Chrome-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-ltr-light-Mobile-Chrome-linux.png index 35924bc964..74b5b7722c 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-ltr-light-Mobile-Chrome-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-ltr-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-ltr-light-Mobile-Firefox-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-ltr-light-Mobile-Firefox-linux.png index 5a87f1d7ec..971a058b54 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-ltr-light-Mobile-Firefox-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-ltr-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-ltr-light-Mobile-Safari-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-ltr-light-Mobile-Safari-linux.png index a0b4a0cb4b..24521c97ea 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-ltr-light-Mobile-Safari-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-ltr-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-rtl-light-Mobile-Chrome-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-rtl-light-Mobile-Chrome-linux.png index e39e6b3741..f30c065f15 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-rtl-light-Mobile-Chrome-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-rtl-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-rtl-light-Mobile-Firefox-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-rtl-light-Mobile-Firefox-linux.png index 52eddfa557..61ef961d38 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-rtl-light-Mobile-Firefox-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-rtl-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-rtl-light-Mobile-Safari-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-rtl-light-Mobile-Safari-linux.png index f38b30ac5a..f5bf03a4c3 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-rtl-light-Mobile-Safari-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-fixed-justify-start-ionic-md-rtl-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-ltr-light-Mobile-Chrome-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-ltr-light-Mobile-Chrome-linux.png index 60efa62e49..1bddc8014b 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-ltr-light-Mobile-Chrome-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-ltr-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-ltr-light-Mobile-Firefox-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-ltr-light-Mobile-Firefox-linux.png index 7e20cf582f..9d9f6726aa 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-ltr-light-Mobile-Firefox-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-ltr-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-ltr-light-Mobile-Safari-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-ltr-light-Mobile-Safari-linux.png index 830aa99aee..f32b42d86d 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-ltr-light-Mobile-Safari-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-ltr-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-rtl-light-Mobile-Chrome-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-rtl-light-Mobile-Chrome-linux.png index edbd66b4cf..54025b4423 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-rtl-light-Mobile-Chrome-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-rtl-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-rtl-light-Mobile-Firefox-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-rtl-light-Mobile-Firefox-linux.png index 9f659ce48e..45c3a7264c 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-rtl-light-Mobile-Firefox-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-rtl-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-rtl-light-Mobile-Safari-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-rtl-light-Mobile-Safari-linux.png index c6562df3e0..9d0d8e5b28 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-rtl-light-Mobile-Safari-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-long-label-ionic-md-rtl-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-ltr-light-Mobile-Chrome-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-ltr-light-Mobile-Chrome-linux.png index 60efa62e49..1bddc8014b 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-ltr-light-Mobile-Chrome-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-ltr-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-ltr-light-Mobile-Firefox-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-ltr-light-Mobile-Firefox-linux.png index 7e20cf582f..9d9f6726aa 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-ltr-light-Mobile-Firefox-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-ltr-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-ltr-light-Mobile-Safari-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-ltr-light-Mobile-Safari-linux.png index 830aa99aee..f32b42d86d 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-ltr-light-Mobile-Safari-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-ltr-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-rtl-light-Mobile-Chrome-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-rtl-light-Mobile-Chrome-linux.png index edbd66b4cf..54025b4423 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-rtl-light-Mobile-Chrome-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-rtl-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-rtl-light-Mobile-Firefox-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-rtl-light-Mobile-Firefox-linux.png index 9f659ce48e..45c3a7264c 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-rtl-light-Mobile-Firefox-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-rtl-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-rtl-light-Mobile-Safari-linux.png b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-rtl-light-Mobile-Safari-linux.png index c6562df3e0..9d0d8e5b28 100644 Binary files a/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-rtl-light-Mobile-Safari-linux.png and b/core/src/components/radio/test/label-placement/radio.e2e.ts-snapshots/radio-label-start-justify-start-long-label-ionic-md-rtl-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/select-modal/select-modal.scss b/core/src/components/select-modal/select-modal.common.scss similarity index 100% rename from core/src/components/select-modal/select-modal.scss rename to core/src/components/select-modal/select-modal.common.scss diff --git a/core/src/components/select-modal/select-modal.ionic.scss b/core/src/components/select-modal/select-modal.ionic.scss new file mode 100644 index 0000000000..1823fdad9c --- /dev/null +++ b/core/src/components/select-modal/select-modal.ionic.scss @@ -0,0 +1,65 @@ +@use "../../themes/ionic/ionic.globals.scss" as globals; +@use "./select-modal.common"; + +// Ionic Select Modal +// -------------------------------------------------- + +// Item +// ---------------------------------------------------------------- + +ion-item { + --border-width: 0; +} + +// Toolbar +// ---------------------------------------------------------------- + +ion-toolbar { + @include globals.typography(globals.$ion-heading-h6-medium); +} + +// Radio +// ---------------------------------------------------------------- + +ion-list ion-radio::part(container) { + display: none; +} + +ion-list ion-radio::part(label) { + @include globals.margin(0); +} + +// Radio and Checkbox: Label +// ---------------------------------------------------------------- + +ion-list ion-radio::part(label), +ion-list ion-checkbox::part(label) { + @include globals.typography(globals.$ion-body-lg-medium); +} + +// Radio and Checkbox: Checked +// ---------------------------------------------------------------- + +.item-radio-checked, +.item-checkbox-checked { + --background: #{globals.$ion-semantics-primary-100}; + --border-radius: #{globals.$ion-border-radius-400}; +} + +// Content +// ---------------------------------------------------------------- + +ion-content { + /** + * The important is needed to override the padding set + * for modal sheet by the `core.ionic.scss` file. + * The modal sheet within the select does not match the + * padding of the modal sheet in the core. + */ + /* stylelint-disable-next-line declaration-no-important */ + --padding-start: #{globals.$ion-space-400} !important; + /* stylelint-disable-next-line declaration-no-important */ + --padding-end: #{globals.$ion-space-400} !important; + /* stylelint-disable-next-line declaration-no-important */ + --padding-bottom: #{globals.$ion-space-1200} !important; +} diff --git a/core/src/components/select-modal/select-modal.ios.scss b/core/src/components/select-modal/select-modal.ios.scss index 7e60b693fc..ab42228932 100644 --- a/core/src/components/select-modal/select-modal.ios.scss +++ b/core/src/components/select-modal/select-modal.ios.scss @@ -1 +1 @@ -@import "./select-modal"; +@import "./select-modal.common"; diff --git a/core/src/components/select-modal/select-modal.md.scss b/core/src/components/select-modal/select-modal.md.scss index be64d9ae90..505ea2a061 100644 --- a/core/src/components/select-modal/select-modal.md.scss +++ b/core/src/components/select-modal/select-modal.md.scss @@ -1,4 +1,4 @@ -@import "./select-modal"; +@import "./select-modal.common"; @import "../../themes/mixins.scss"; @import "../item/item.md.vars"; diff --git a/core/src/components/select-modal/select-modal.tsx b/core/src/components/select-modal/select-modal.tsx index ad92786043..74b9a890a4 100644 --- a/core/src/components/select-modal/select-modal.tsx +++ b/core/src/components/select-modal/select-modal.tsx @@ -14,7 +14,7 @@ import type { SelectModalOption } from './select-modal-interface'; styleUrls: { ios: 'select-modal.ios.scss', md: 'select-modal.md.scss', - ionic: 'select-modal.md.scss', + ionic: 'select-modal.ionic.scss', }, scoped: true, }) diff --git a/core/src/components/select-modal/test/basic/select-modal.e2e.ts b/core/src/components/select-modal/test/basic/select-modal.e2e.ts index 126082712c..677bdb7306 100644 --- a/core/src/components/select-modal/test/basic/select-modal.e2e.ts +++ b/core/src/components/select-modal/test/basic/select-modal.e2e.ts @@ -82,7 +82,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { * do have RTL logic, but those are tested in their * respective component test files. */ -configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { +configs({ modes: ['ios', 'md', 'ionic-md'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { test.describe(title('select-modal: rendering'), () => { let selectModalPage: SelectModalPage; diff --git a/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-diff-ionic-md-ltr-light-Mobile-Chrome-linux.png b/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-diff-ionic-md-ltr-light-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..d0cd18a691 Binary files /dev/null and b/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-diff-ionic-md-ltr-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-diff-ionic-md-ltr-light-Mobile-Firefox-linux.png b/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-diff-ionic-md-ltr-light-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..be792e6c3c Binary files /dev/null and b/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-diff-ionic-md-ltr-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-diff-ionic-md-ltr-light-Mobile-Safari-linux.png b/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-diff-ionic-md-ltr-light-Mobile-Safari-linux.png new file mode 100644 index 0000000000..8549e00b66 Binary files /dev/null and b/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-diff-ionic-md-ltr-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-multiple-diff-ionic-md-ltr-light-Mobile-Chrome-linux.png b/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-multiple-diff-ionic-md-ltr-light-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..b38f5d9280 Binary files /dev/null and b/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-multiple-diff-ionic-md-ltr-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-multiple-diff-ionic-md-ltr-light-Mobile-Firefox-linux.png b/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-multiple-diff-ionic-md-ltr-light-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..c4097000db Binary files /dev/null and b/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-multiple-diff-ionic-md-ltr-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-multiple-diff-ionic-md-ltr-light-Mobile-Safari-linux.png b/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-multiple-diff-ionic-md-ltr-light-Mobile-Safari-linux.png new file mode 100644 index 0000000000..48fb531f24 Binary files /dev/null and b/core/src/components/select-modal/test/basic/select-modal.e2e.ts-snapshots/select-modal-multiple-diff-ionic-md-ltr-light-Mobile-Safari-linux.png differ