javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-18 03:00:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(react, vue): do not show back button when replacing to root page (#22750)

Browse Source 
resolves #22528
This commit is contained in:
Liam DeBeasi
2021-01-13 10:10:44 -05:00
committed by GitHub
parent 64719f49f9
commit 9e9a372497
5 changed files with 55 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/vue/test-app/src/views/Home.vue
View File

@ -2,6 +2,9 @@
<ion-page data-pageid="home">
<ion-header :translucent="true">
<ion-toolbar>
<ion-buttons slot="start">
<ion-back-button></ion-back-button>
</ion-buttons>
<ion-title>Test App</ion-title>
</ion-toolbar>
</ion-header>
@ -54,12 +57,14 @@
</template>
<script lang="ts">
import { IonContent, IonHeader, IonItem, IonLabel, IonList, IonPage, IonTitle, IonToolbar } from '@ionic/vue';
import { IonButtons, IonBackButton, IonContent, IonHeader, IonItem, IonLabel, IonList, IonPage, IonTitle, IonToolbar } from '@ionic/vue';
import { defineComponent } from 'vue';
export default defineComponent({
name: 'Home',
components: {
IonButtons,
IonBackButton,
IonContent,
IonHeader,
IonItem,

15
packages/vue/test-app/tests/e2e/specs/routing.js
View File

@ -176,6 +176,21 @@ describe('Routing', () => {
cy.ionPageVisible('navigation');
cy.ionPageHidden('routingparameter');
});
// Verifies fix for https://github.com/ionic-team/ionic-framework/issues/22528
it('should not show ion-back-button when replacing to root page', () => {
cy.visit('http://localhost:8080');
cy.routerPush('/navigation');
cy.ionPageVisible('navigation');
cy.ionPageHidden('home');
cy.routerReplace('/');
cy.ionPageDoesNotExist('navigation');
cy.ionPageVisible('home');
cy.ionBackButtonHidden('home');
});
});
describe('Routing - Swipe to Go Back', () => {

15
packages/vue/test-app/tests/e2e/support/commands.js
View File

@ -76,4 +76,17 @@ Cypress.Commands.add('routerPush', (path) => {
cy.window().then(win => {
win.debugRouter.push(path);
});
})
});
Cypress.Commands.add('routerReplace', (path) => {
cy.window().then(win => {
win.debugRouter.replace(path);
});
});
Cypress.Commands.add('ionBackButtonHidden', (pageId) => {
cy.get(`div.ion-page[data-pageid=${pageId}]`)
.should('be.visible', true)
.find('ion-back-button')
.should('not.be.visible')
});