fix(datetime): don't update value on confirm call if no date was selected (#25338)

This commit is contained in:
Amanda Johnston
2022-05-24 09:29:31 -05:00
committed by GitHub
parent 0156be61cb
commit 9e5b10a215
2 changed files with 35 additions and 10 deletions

View File

@ -441,6 +441,13 @@ export class Datetime implements ComponentInterface {
*/ */
@Method() @Method()
async confirm(closeOverlay = false) { async confirm(closeOverlay = false) {
/**
* If highlightActiveParts is false, this means the datetime was inited
* without a value, and the user hasn't selected one yet. We shouldn't
* update the value in this case, since otherwise it would be mysteriously
* set to today.
*/
if (this.highlightActiveParts) {
/** /**
* Prevent convertDataToISO from doing any * Prevent convertDataToISO from doing any
* kind of transformation based on timezone * kind of transformation based on timezone
@ -454,6 +461,7 @@ export class Datetime implements ComponentInterface {
this.activeParts.tzOffset = date.getTimezoneOffset() * -1; this.activeParts.tzOffset = date.getTimezoneOffset() * -1;
this.value = convertDataToISO(this.activeParts); this.value = convertDataToISO(this.activeParts);
}
if (closeOverlay) { if (closeOverlay) {
this.closeParentOverlay(); this.closeParentOverlay();

View File

@ -29,3 +29,20 @@ test.describe('datetime: selecting a day', () => {
await testHighlight(page, 'custom-datetime'); await testHighlight(page, 'custom-datetime');
}); });
}); });
test.describe('datetime: confirm date', () => {
test('should not update value if Done was clicked without selecting a day first', async ({ page }) => {
await page.goto('/src/components/datetime/test/basic');
const datetime = page.locator('#custom-datetime');
const value = await datetime.evaluate((el: HTMLIonDatetimeElement) => el.value);
expect(value).toBeUndefined();
await datetime.evaluate(async (el: HTMLIonDatetimeElement) => {
await el.confirm();
});
const valueAgain = await datetime.evaluate((el: HTMLIonDatetimeElement) => el.value);
expect(valueAgain).toBeUndefined();
});
});