diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c1194c6998..30b9b2dfba 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -55,8 +55,8 @@ jobs: # add new items to the shard array # and change the value of totalShards # to be the length of the shard array. - shard: [1, 2, 3, 4, 5] - totalShards: [5] + shard: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20] + totalShards: [20] needs: [build-core] runs-on: ubuntu-latest steps: @@ -66,6 +66,24 @@ jobs: shard: ${{ matrix.shard }} totalShards: ${{ matrix.totalShards }} + # Screenshots are required to pass + # in order for the branch to be merge + # eligible. However, the screenshot tests + # are run on n runners where n can change + # over time. The verify-screenshots step allows + # us to have a required status check for screenshot + # results without having to manually add each + # matrix run in the branch protection rules + # Source: https://github.community/t/status-check-for-a-matrix-jobs/127354 + verify-screenshots: + if: ${{ always() }} + needs: test-core-screenshot + runs-on: ubuntu-latest + steps: + - name: Check build matrix status + if: ${{ needs.test-core-screenshot.result != 'success' }} + run: exit 1 + build-vue: needs: [build-core] runs-on: ubuntu-latest diff --git a/.github/workflows/update-screenshots.yml b/.github/workflows/update-screenshots.yml index 9df9a36608..d8c65a6417 100644 --- a/.github/workflows/update-screenshots.yml +++ b/.github/workflows/update-screenshots.yml @@ -23,8 +23,8 @@ jobs: # add new items to the shard array # and change the value of totalShards # to be the length of the shard array. - shard: [1, 2, 3, 4, 5] - totalShards: [5] + shard: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20] + totalShards: [20] needs: [build-core] runs-on: ubuntu-latest steps: