From 9e11fcb2bb504916a1ef910a011f80b93be36109 Mon Sep 17 00:00:00 2001 From: Shane Date: Thu, 20 Mar 2025 13:17:25 -0700 Subject: [PATCH] test(angular): fixing over-import of RouterModule in the standalone router-link test (#30285) Issue number: resolves internal --------- ## What is the current behavior? Currently the standalone test app for router-link in Angular imports all of `RouterModule` when it only needs to import `RouterLink` from `@angular/router` ## What is the new behavior? Now, the Angular test app will import only what it needs from router instead of over-importing. ## Does this introduce a breaking change? - [ ] Yes - [X] No ## Other information This PR helps align our Angular test apps with a more real-world implementation expectation --- .../base/src/app/standalone/app-standalone/app.component.ts | 5 ++--- .../src/app/standalone/router-link/router-link.component.ts | 4 ++-- .../test/base/src/app/standalone/standalone.component.ts | 3 +-- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/angular/test/base/src/app/standalone/app-standalone/app.component.ts b/packages/angular/test/base/src/app/standalone/app-standalone/app.component.ts index d51d38c860..7940f8d10e 100644 --- a/packages/angular/test/base/src/app/standalone/app-standalone/app.component.ts +++ b/packages/angular/test/base/src/app/standalone/app-standalone/app.component.ts @@ -1,12 +1,11 @@ import { Component } from '@angular/core'; -import { RouterModule } from '@angular/router'; -import { IonRouterOutlet, IonApp } from '@ionic/angular/standalone'; +import { IonApp, IonRouterOutlet } from '@ionic/angular/standalone'; @Component({ selector: 'app-root-standalone', templateUrl: './app.component.html', standalone: true, - imports: [RouterModule, IonRouterOutlet, IonApp] + imports: [IonRouterOutlet, IonApp] }) export class AppComponent { } diff --git a/packages/angular/test/base/src/app/standalone/router-link/router-link.component.ts b/packages/angular/test/base/src/app/standalone/router-link/router-link.component.ts index 4e0e1bcff3..31653f3bb0 100644 --- a/packages/angular/test/base/src/app/standalone/router-link/router-link.component.ts +++ b/packages/angular/test/base/src/app/standalone/router-link/router-link.component.ts @@ -1,11 +1,11 @@ import { Component } from '@angular/core'; -import { RouterModule } from '@angular/router'; +import { RouterLink } from '@angular/router'; import { IonRouterLink, IonRouterLinkWithHref } from '@ionic/angular/standalone'; @Component({ selector: 'app-router-link', templateUrl: './router-link.component.html', standalone: true, - imports: [RouterModule, IonRouterLink, IonRouterLinkWithHref], + imports: [RouterLink, IonRouterLink, IonRouterLinkWithHref], }) export class RouterLinkComponent {} diff --git a/packages/angular/test/base/src/app/standalone/standalone.component.ts b/packages/angular/test/base/src/app/standalone/standalone.component.ts index 56f6f8a92b..9b707ade83 100644 --- a/packages/angular/test/base/src/app/standalone/standalone.component.ts +++ b/packages/angular/test/base/src/app/standalone/standalone.component.ts @@ -1,5 +1,4 @@ import { Component } from "@angular/core"; -import { RouterModule } from "@angular/router"; import { IonicModule } from '@ionic/angular'; @@ -7,6 +6,6 @@ import { IonicModule } from '@ionic/angular'; selector: 'app-standalone', templateUrl: './standalone.component.html', standalone: true, - imports: [IonicModule, RouterModule] + imports: [IonicModule] }) export class StandaloneComponent { }